Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Models representation in Docs Modal #1481

Closed
2 of 12 tasks
smk4664 opened this issue Mar 11, 2022 · 4 comments · Fixed by #1601
Closed
2 of 12 tasks

Plugin Models representation in Docs Modal #1481

smk4664 opened this issue Mar 11, 2022 · 4 comments · Fixed by #1601
Assignees
Labels
type: documentation Improvements or additions to documentation type: feature Introduction of new or enhanced functionality to the application

Comments

@smk4664
Copy link
Contributor

smk4664 commented Mar 11, 2022

As ...

P.D. - Plugin Developer

I want ...

A way to store my model documentation.

So that ...

My users can click on the help icon on the Object Edit View and see the documentation for the plugin model.

I know this is done when...

  • I can create a Nautobot Plugin and have the ability to specify a docs directory.
  • The Docs directory of my plugin gets loaded to DOCS_ROOT like Static files go to STATIC ROOT.
  • I can view the docs for my plugin model on the Object Edit view by clicking on the blue help icon.

Optional - Feature groups this request pertains to.

  • Automation
  • Circuits
  • DCIM
  • IPAM
  • Misc (including Data Sources)
  • Organization
  • Plugins (and other Extensibility)
  • Security (Secrets, etc)
  • Image Management
  • UI/UX
  • Documentation
  • Other (not directly a platform feature)

Database Changes

No response

External Dependencies

No response

@smk4664 smk4664 added the type: feature Introduction of new or enhanced functionality to the application label Mar 11, 2022
@glennmatthews glennmatthews added the type: documentation Improvements or additions to documentation label Mar 11, 2022
@glennmatthews
Copy link
Contributor

I’d really like to see us tackle inline help more holistically - the current pattern (where you can access only the docs/models/<app>/<model>.md within the application, and it’s rendered on-the-fly without support for things like cross-reference links between pages) is very much less than desirable. I’d rather see us render the entire docs tree as part of the package build and embed the rendered HTML into the package so that all of the docs can be accessed offline.

NetBox did something similar in netbox-community/netbox#6769 and netbox-community/netbox@3ec0fe5, though our approach will need to be somewhat different as we want to render the docs at build time, not at install time.

@glennmatthews
Copy link
Contributor

That said we will also need a pattern for allowing plugin docs to additionally be included in plugin packages and making them accessible as well - AFAIK NetBox hasn't addressed that requirement.

@smk4664
Copy link
Contributor Author

smk4664 commented Mar 29, 2022

Sure, I will try to tackle both then.

@smk4664
Copy link
Contributor Author

smk4664 commented Mar 29, 2022

After reviewing what Netbox did, this is very similar to what I had in mind. I am working on a proof of concept with the test plugin.

bryanculver added a commit that referenced this issue Apr 28, 2022
@glennmatthews glennmatthews mentioned this issue May 2, 2022
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: documentation Improvements or additions to documentation type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants