Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Operation Schema Views are Incorrect #1619

Closed
bryanculver opened this issue Apr 7, 2022 · 1 comment · Fixed by #2398
Closed

Bulk Operation Schema Views are Incorrect #1619

bryanculver opened this issue Apr 7, 2022 · 1 comment · Fixed by #2398
Assignees
@glennmatthews
Labels
type: bug Something isn't working as expected

Comments

@bryanculver
Copy link
Member

Environment

  • Python version: 3.6+
  • Nautobot version: 1.2+ (confirmed in next as well)

Steps to Reproduce

  1. View https://demo.nautobot.com/api/docs/#operations-ipam-ipam_ip-addresses_bulk_partial_update

Expected Behavior

Schema for bulk update should be a list of the models.

Observed Behavior

Schema shows as a single object for the bulk update methods.
@bryanculver bryanculver added the type: bug Something isn't working as expected label Apr 7, 2022
@bryanculver bryanculver changed the title Bulk Operation Scheme Views are Incorrect Bulk Operation Schema Views are Incorrect Apr 8, 2022
@glennmatthews
Copy link
Contributor

This appears to still be an issue after #1544.

@glennmatthews glennmatthews self-assigned this Sep 2, 2022
glennmatthews added a commit that referenced this issue Sep 9, 2022
@glennmatthews
Various fixes to bulk operation schema generation (#1619)
3f77b72
@glennmatthews glennmatthews mentioned this issue Sep 9, 2022
Merged
3 tasks
glennmatthews added a commit that referenced this issue Sep 16, 2022
@glennmatthews
Fixes to OpenAPI schema for bulk API operations (#2398)
cee95f1 
* Various fixes to bulk operation schema generation (#1619)

* Fix Status enum collisions

* Regenerate poetry.lock with poetry 1.2

* Special-case serializer for bulk Group operations due to integer PK.

* Override get_operation() instead of _get_request_body()

* Add changelog fragments

* Update to drf-spectacular 0.24

* Update comment in nautobot/core/settings.py
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to OpenAPI schema for bulk API operations nautobot/nautobot
2 participants
@bryanculver @glennmatthews