Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provided data types on git repository detailed view dont show ✅ for related type. #1841

Closed
jeffkala opened this issue Jun 2, 2022 · 1 comment · Fixed by #1863
Closed
Labels
type: bug Something isn't working as expected

Comments

@jeffkala
Copy link
Contributor

jeffkala commented Jun 2, 2022

Environment

  • Python version: 3.7
  • Nautobot version: 1.3.5

Steps to Reproduce

  1. Create/Sync a git data source.
  2. Click on the detailed view for that git-repository
  3. On the right hand pane under provided data types all show ❌ even though the edit view for that git repository has a data source properly selected.

Expected Behavior

✅ for the data source type the repository is related to.

Observed Behavior

All show ❌ even though the edit view for that git repository has a data source properly selected.

@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Jun 2, 2022
@glennmatthews
Copy link
Contributor

Looks like a bug introduced by #1212. The following diff appears to fix it:

diff --git a/nautobot/extras/templates/extras/gitrepository.html b/nautobot/extras/templates/extras/gitrepository.html
index 9b269f108..ca230793a 100644
--- a/nautobot/extras/templates/extras/gitrepository.html
+++ b/nautobot/extras/templates/extras/gitrepository.html
@@ -78,9 +78,9 @@
                                 {{ entry.name|title }}</td>
                             <td>
                                 {% if entry.content_identifier in object.provided_contents %}
-                                    {{ true | render_boolean }}
+                                    {{ True | render_boolean }}
                                 {% else %}
-                                    {{ false | render_boolean }}
+                                    {{ False | render_boolean }}
                                 {% endif %}
                             </td>
                         </tr>

@glennmatthews glennmatthews linked a pull request Jun 9, 2022 that will close this issue
6 tasks
bryanculver added a commit that referenced this issue Jun 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants