Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Jobs to be marked as read-only #200

Closed
progala opened this issue Mar 26, 2021 · 1 comment · Fixed by #511
Closed

Allow Jobs to be marked as read-only #200

progala opened this issue Mar 26, 2021 · 1 comment · Fixed by #511
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
Release v1.1.0
Milestone
v1.1.0

Comments

@progala
Copy link

progala commented Mar 26, 2021

Environment

  • Python version: Python 3.8.5
  • Nautobot version: 1.0.0b2

Proposed Functionality

It would be helpful to be able to mark a Job as being read-only, i.e. not modifying the database. This would then remove "Commit message" checkbox from the Job form, and would stop "Database changes..." log messages from showing up in the Job results.

Use Case

As an end user running Jobs that are read-only (formerly known as Reports) I might not understand why I'm seeing the "Commit changes" checkbox and why "Database changes..." logs show up in Job results.

As a programmer writing a Job I want to be able to specify that given Job will not modify database objects.

Database Changes

None.

External Dependencies

None.
@jathanism jathanism added type: feature Introduction of new or enhanced functionality to the application status: under review labels Mar 26, 2021
@jathanism
Copy link
Contributor

Thanks @progala for submitting this. :)

@jedelman8 jedelman8 added this to the v1.1.0 milestone Apr 7, 2021
@jedelman8 jedelman8 added this to To do in Release v1.1.0 via automation Apr 29, 2021
lampwins added a commit to lampwins/nautobot that referenced this issue May 30, 2021
@lampwins
closes nautobot#200 - added a Meta attribute to BaseClass that forces…
0218f50 
… and related UX
@lampwins lampwins mentioned this issue May 30, 2021
Merged
lampwins added a commit that referenced this issue Jun 2, 2021
@lampwins @glennmatthews @jathanism
200 read only jobs (#511)
a9898d1 
* closes #200 - added a  Meta attribute to BaseClass that forces  and related UX

* added read-only UI labels

* remove print statement

* fix test case name

* Update nautobot/docs/additional-features/jobs.md

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Update nautobot/docs/additional-features/jobs.md

Co-authored-by: Jathan McCollum <jathan@gmail.com>

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Jathan McCollum <jathan@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Release v1.1.0
To do
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

200 read only jobs lampwins/nautobot
4 participants
@jathanism @glennmatthews @jedelman8 @progala