Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rqworker container from default docker development environment #2002

Closed
glennmatthews opened this issue Jul 5, 2022 · 1 comment · Fixed by #2024
Closed

Remove rqworker container from default docker development environment #2002

glennmatthews opened this issue Jul 5, 2022 · 1 comment · Fixed by #2024
Assignees
@glennmatthews
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@glennmatthews
Copy link
Contributor

Proposed Changes

Nothing in Nautobot core requires rqworker at this point in time, and hasn't since 1.1. But our default docker-compose.yml still includes a container running rqworker. We should consider removing this container for efficiency.

Justification

Reduced overhead of dev environment.

The only risk I can think of is if:

  1. We make some change that breaks the rqworker and don't detect it because of this removal
  2. A user is running latest Nautobot but still has a custom plugin that's using the rqworker rather than Celery
    then we might have an issue.
@glennmatthews glennmatthews added the type: housekeeping Changes to the application which do not directly impact the end user label Jul 5, 2022
@glennmatthews glennmatthews self-assigned this Jul 8, 2022
glennmatthews added a commit that referenced this issue Jul 8, 2022
@glennmatthews
Fix #2002 - remove RQ worker container from docker-compose default en…
f374953 
…vironment
@glennmatthews glennmatthews mentioned this issue Jul 8, 2022
Merged
@glennmatthews glennmatthews linked a pull request Jul 8, 2022 that will close this issue
Remove RQ worker container from docker-compose development environment #2024
Merged
bryanculver pushed a commit that referenced this issue Jul 12, 2022
@glennmatthews
Fix #2002 - remove RQ worker container from docker-compose default en…
14eaf7c 
…vironment (#2024)
@bryanculver
Copy link
Member

Closed in #2024

bryanculver added a commit that referenced this issue Jul 12, 2022
@bryanculver
Add release-note for #1945, #1949, #2002
a413b14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove RQ worker container from docker-compose development environment nautobot/nautobot
2 participants
@bryanculver @glennmatthews