Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ChangeLoggedModel.created from a DateField to a DateTimeField #2076

Closed
2 of 12 tasks
glennmatthews opened this issue Jul 19, 2022 · 1 comment · Fixed by #3316
Closed
2 of 12 tasks

Change ChangeLoggedModel.created from a DateField to a DateTimeField #2076

glennmatthews opened this issue Jul 19, 2022 · 1 comment · Fixed by #3316
Assignees
@glennmatthews
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: feature Introduction of new or enhanced functionality to the application
Milestone
v2.0.0

Comments

@glennmatthews
Copy link
Contributor

glennmatthews commented Jul 19, 2022 •
edited by bryanculver

As ...

Dan - Data Owner

I want ...

The created field on all change-logged models to include a time stamp as well as a date, rather than just a date with no associated time information.

So that ...

I can have more granular insight into when data was first entered into Nautobot, especially as part of a global operation spanning multiple time zones.

I know this is done when...

  • Objects automatically store a timestamp as well as a datestamp when first created.
  • Object detail pages show the timestamp as well as the datestamp as the "Created ..." text below the page header

Optional - Feature groups this request pertains to.

  • Automation
  • Circuits
  • DCIM
  • IPAM
  • Misc (including Data Sources)
  • Organization
  • Plugins (and other Extensibility)
  • Security (Secrets, etc)
  • Image Management
  • UI/UX
  • Documentation
  • Other (not directly a platform feature)

Database Changes

  • Change ChangeLoggedModel.created from a DateField to a DateTimeField.
  • Implement data migration for existing models.
    • Midnight on the same day is sufficient, just needs to be documented
    • May already be addressed in the column/field migration

External Dependencies

None expected.
@glennmatthews glennmatthews added the type: feature Introduction of new or enhanced functionality to the application label Jul 19, 2022
@glennmatthews glennmatthews mentioned this issue Jul 19, 2022
Merged
10 tasks
@glennmatthews glennmatthews added the impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release label Oct 3, 2022
@bryanculver bryanculver added this to the v2.0.0 milestone Nov 3, 2022
@timizuoebideri1 timizuoebideri1 self-assigned this Nov 10, 2022
@glennmatthews glennmatthews self-assigned this Feb 14, 2023
glennmatthews added a commit that referenced this issue Feb 14, 2023
@glennmatthews
Fix #2076 - change created field to a DateTimeField
e6415a3
glennmatthews added a commit that referenced this issue Feb 14, 2023
@glennmatthews
Fix #2076 - change created field to a DateTimeField
ce12044
@glennmatthews glennmatthews mentioned this issue Feb 14, 2023
Merged
7 tasks
@glennmatthews glennmatthews linked a pull request Feb 14, 2023 that will close this issue
Fix #2076 - change created field to a DateTimeField #3316
Merged
7 tasks
glennmatthews added a commit that referenced this issue Feb 16, 2023
@glennmatthews
Fix #2076 - change created field to a DateTimeField (#3316)
348b3b2 
* Fix #2076 - change created field to a DateTimeField

* Testing fix?

* Fix long-standing migration bug

* Import order
@glennmatthews
Copy link
Contributor Author

Implemented in #3316

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Fix #2076 - change created field to a DateTimeField nautobot/nautobot
4 participants
@bryanculver @glennmatthews @paulbukauskas @timizuoebideri1