Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphiQL page doesn't support dark-mode at present #2209

Closed
bryanculver opened this issue Aug 15, 2022 · 0 comments · Fixed by #2234
Closed

GraphiQL page doesn't support dark-mode at present #2209

bryanculver opened this issue Aug 15, 2022 · 0 comments · Fixed by #2234
Assignees
@HanlinMiao
Labels
type: bug Something isn't working as expected type: feature Introduction of new or enhanced functionality to the application
Milestone
v1.4.1

Comments

@bryanculver
Copy link
Member

Doesn't look like our GraphiQL page actually supports dark-mode at present - bug/feature?

Originally posted by @glennmatthews in #2046 (comment)
@bryanculver bryanculver mentioned this issue Aug 15, 2022
Closed
1 task
@glennmatthews glennmatthews changed the title GraphiQL page actually supports dark-mode at present GraphiQL page doesn't support dark-mode at present Aug 15, 2022
@bryanculver bryanculver added type: bug Something isn't working as expected type: feature Introduction of new or enhanced functionality to the application group: ui-ux labels Aug 16, 2022
@HanlinMiao HanlinMiao self-assigned this Aug 17, 2022
@HanlinMiao HanlinMiao linked a pull request Aug 17, 2022 that will close this issue
Closing #2209 #2234
Merged
HanlinMiao added a commit that referenced this issue Aug 18, 2022
@HanlinMiao
Closing #2209 (#2234)
9f7db56 
* deleted disabled=disabled from graphiql.html

* delete extra space

* it seems like we forgot to include the modal_theme.html in graphiql.html

* add extra space

* added footer to graphiql page

Co-authored-by: Hanlin Miao <hanlinmiao@Hanlins-MBP-2.home>
HanlinMiao pushed a commit that referenced this issue Aug 18, 2022
added documentation for #2209
dcdc3d4
@bryanculver bryanculver added this to the v1.4.1 milestone Aug 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HanlinMiao HanlinMiao

Labels
type: bug Something isn't working as expected type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v1.4.1
Development

Successfully merging a pull request may close this issue.

Closing #2209 nautobot/nautobot
2 participants
@bryanculver @HanlinMiao