Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oauthlib from 3.2.0 to 3.2.1 #2434

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2022

Bumps oauthlib from 3.2.0 to 3.2.1.

Release notes

Sourced from oauthlib's releases.

3.2.1

In short

OAuth2.0 Provider:

OAuth1.0:

  • #818 : Allow IPv6 being parsed by signature

General:

  • Improved and fixed documentation warnings.
  • Cosmetic changes based on isort

What's Changed

New Contributors

Full Changelog: oauthlib/oauthlib@v3.2.0...v3.2.1

Changelog

Sourced from oauthlib's changelog.

3.2.1 (2022-09-09)

OAuth2.0 Provider:

OAuth1.0:

  • #818: Allow IPv6 being parsed by signature

General:

  • Improved and fixed documentation warnings.
  • Cosmetic changes based on isort
Commits
  • 88bb156 Updated date and authors
  • 1a45d97 Prepare 3.2.1 release
  • 0adbbe1 docs: fix typos
  • 6569ec3 docs: Fix a few typos
  • bdc486e Fixed isort imports
  • 7db45bd Fix typo in server.rst
  • b14ad85 chore: s/bode_code_verifier/body_code_verifier/g
  • b123283 Allow non-HTTPS issuer when OAUTHLIB_INSECURE_TRANSPORT. (#803)
  • 2f887b5 Docs: fix Sphinx warnings for better ReadTheDocs generation (#807)
  • d4bafd9 Merge pull request #797 from cclauss/patch-2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Sep 16, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 19, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/oauthlib-3.2.1 branch September 19, 2022 13:31
@bryanculver bryanculver restored the dependabot/pip/oauthlib-3.2.1 branch September 28, 2022 23:10
@bryanculver bryanculver reopened this Sep 28, 2022
@bryanculver
Copy link
Member

@nautobot/core This is coming in via social-auth-core. I know we don't want to pin our dependencies' dependencies just to address CVEs. Should we have admins/announcement list that users may want to pip install oauthlib --upgrade?

Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/oauthlib/oauthlib/releases)
- [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst)
- [Commits](oauthlib/oauthlib@v3.2.0...v3.2.1)

---
updated-dependencies:
- dependency-name: oauthlib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/oauthlib-3.2.1 branch from a3afb7a to 0a132a8 Compare September 28, 2022 23:25
@nniehoff
Copy link
Contributor

@nautobot/core This is coming in via social-auth-core. I know we don't want to pin our dependencies' dependencies just to address CVEs. Should we have admins/announcement list that users may want to pip install oauthlib --upgrade?

This seems like a horrible idea to me.... If we are using poetry for dependency management we shouldn't use pip to upgrade... I feel like if you want to recommend something we should recommend poetry update instead.

@bryanculver
Copy link
Member

@nautobot/core This is coming in via social-auth-core. I know we don't want to pin our dependencies' dependencies just to address CVEs. Should we have admins/announcement list that users may want to pip install oauthlib --upgrade?

This seems like a horrible idea to me.... If we are using poetry for dependency management we shouldn't use pip to upgrade... I feel like if you want to recommend something we should recommend poetry update instead.

Poetry isn't documented to manage dependencies for end-users. Our installation documentation specifically says pip3 install nautobot: https://docs.nautobot.com/projects/core/en/stable/installation/nautobot/#install-nautobot

Since this is a dependency of a dependency installations won't automagically upgrade the version when they upgrade Nautobot unless we require it as a minimum version. The poetry.lock file has no bearing on what the package requirements specify.

@bryanculver
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 30, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@bryanculver bryanculver merged commit 89c443a into develop Oct 12, 2022
@bryanculver bryanculver deleted the dependabot/pip/oauthlib-3.2.1 branch October 12, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants