Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch CSRF Failure when DEBUG=False #2437

Closed
1 of 12 tasks
whitej6 opened this issue Sep 17, 2022 · 0 comments · Fixed by #2438
Closed
1 of 12 tasks

Catch CSRF Failure when DEBUG=False #2437

whitej6 opened this issue Sep 17, 2022 · 0 comments · Fixed by #2438
Labels
type: feature Introduction of new or enhanced functionality to the application

Comments

@whitej6
Copy link
Contributor

whitej6 commented Sep 17, 2022

As ...

Patti - Platform Admin

I want ...

the 403 CSRF failure to not render the default Django failure html when DEBUG is set to False

So that ...

When errors occur in Nautobot a user remains in a view that has the same look and feel as nautobot and not a generic view without styling.

I know this is done when...

  • When form is submitted without CSRF token AND DEBUG is set to False a stylized view is returned with the error.
  • When form is submitted and fails CSRF validation AND DEBUG is set to False a stylized view is returned with the error.
  • When form is submitted without CSRF token AND DEBUG is set to True the default Django view is returned.
  • When form is submitted and fails CSRF validation AND DEBUG is set to True the default Django view is returned.

Optional - Feature groups this request pertains to.

  • Automation
  • Circuits
  • DCIM
  • IPAM
  • Misc (including Data Sources)
  • Organization
  • Plugins (and other Extensibility)
  • Security (Secrets, etc)
  • Image Management
  • UI/UX
  • Documentation
  • Other (not directly a platform feature)

Database Changes

None

External Dependencies

None
@whitej6 whitej6 added the type: feature Introduction of new or enhanced functionality to the application label Sep 17, 2022
whitej6 added a commit to whitej6/nautobot that referenced this issue Sep 17, 2022
@whitej6
Resolves nautobot#2437 - Catch CSRF Failure when DEBUG=False
479ec02
@whitej6 whitej6 mentioned this issue Sep 17, 2022
Merged
6 tasks
bryanculver pushed a commit that referenced this issue Oct 11, 2022
@whitej6
Resolves #2437 - Catch CSRF Failure when DEBUG=False (#2438)
bfd2848
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #2437 - Catch CSRF Failure when DEBUG=False whitej6/nautobot
1 participant
@whitej6