Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a danger admonition to developer docs about never using pip to install Poetry into Nautobot dev environment. #2588

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

jathanism
Copy link
Contributor

@jathanism jathanism commented Oct 7, 2022

Closes: #DNE

What's Changed

This is to warn developers to never pip install Poetry into a Nautobot dev. environment, and to only use the official Poetry installer for using poetry for dev.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@glennmatthews
Copy link
Contributor

cough

.github/workflows/prerelease.yml:        run: "pip install poetry"
.github/workflows/release.yml:        run: "pip install poetry"

@jathanism
Copy link
Contributor Author

jathanism commented Oct 7, 2022

cough

.github/workflows/prerelease.yml:        run: "pip install poetry"
.github/workflows/release.yml:        run: "pip install poetry"

LOL specifically this PR is for development. Those workflows are just used to execute poetry build.

@jathanism jathanism changed the title Add a serious message about never using pip to install Poetry. Add a danger admonition to developer docs about never using pip to install Poetry into Nautobot dev environment. Oct 7, 2022
@jathanism jathanism changed the title Add a danger admonition to developer docs about never using pip to install Poetry into Nautobot dev environment. Added a danger admonition to developer docs about never using pip to install Poetry into Nautobot dev environment. Oct 7, 2022
Copy link
Member

@bryanculver bryanculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think Bash helped you too much in your changelog fragment.

Rest looks good!

changes/2588.added Outdated Show resolved Hide resolved
@jathanism jathanism merged commit acbc3c5 into develop Oct 7, 2022
@jathanism jathanism deleted the jathanism-poetry-install branch October 7, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants