Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child locations up to 1 level down are able to have a site #2669

Closed
amtypaldos opened this issue Oct 21, 2022 · 1 comment · Fixed by #2737
Closed

Child locations up to 1 level down are able to have a site #2669

amtypaldos opened this issue Oct 21, 2022 · 1 comment · Fixed by #2737
Assignees
Labels
type: bug Something isn't working as expected

Comments

@amtypaldos
Copy link

Environment

  • Nautobot version (Docker tag too if applicable): 1.4.5
  • Python version: 3.8.10
  • Database platform, version: Postgres 12.12
  • Middleware(s):

Steps to Reproduce

  1. Create a parent location and attach it to a site
  2. Create a child of the above parent, and attach to a site

Expected Behavior

I expected to be unable to add a child location to a site as I am unable to do so with child locations two levels down, IE the child of a child location.

Observed Behavior

I was able to attach a child location to a site

Screen Shot 2022-10-21 at 12 34 11 PM
Screen Shot 2022-10-21 at 12 34 58 PM

@glennmatthews
Copy link
Contributor

Based on discussion on Slack, it sounds like this may have happened because the "Floor" LocationType was changed to no longer have the "Building" LocationType as its parent. We probably need to disallow changing the parent of a LocationType that's already in use?

@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Oct 21, 2022
@glennmatthews glennmatthews self-assigned this Nov 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants