Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS footer margin is gone and swagger UI authorization box is broken #2789

Closed
gsnider2195 opened this issue Nov 9, 2022 · 2 comments · Fixed by #2790
Closed

CSS footer margin is gone and swagger UI authorization box is broken #2789

gsnider2195 opened this issue Nov 9, 2022 · 2 comments · Fixed by #2790
Assignees
Labels
type: bug Something isn't working as expected

Comments

@gsnider2195
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): v1.5.1b1
  • Python version: 3.10.7
  • Database platform, version: Postgres 13
  • Middleware(s):

Steps to Reproduce

Go to test.nautobot.com, scroll to the footer and then navigate to the API

image
image
image

It looks like this was a regression from #2553. #2747 resolves the footer issue without impacting the margin or the swagger API. Reverting #2553 appears to resolve this issue.

@glennmatthews
Copy link
Contributor

In general if we're making changes to the header and footer, we need to check for impact to:

  1. Ordinary Nautobot UI pages
  2. Swagger UI
  3. GraphiQL

@gsnider2195 gsnider2195 added the type: bug Something isn't working as expected label Nov 9, 2022
@gsnider2195
Copy link
Contributor Author

In general if we're making changes to the header and footer, we need to check for impact to:

  1. Ordinary Nautobot UI pages
  2. Swagger UI
  3. GraphiQL

Agreed. After reverting I made sure this looks ok in large and small viewports on the home page, list view with a lot of objects, swagger ui and graphql. We should also check light mode and dark mode.

@gsnider2195 gsnider2195 self-assigned this Nov 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants