New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize max_length
globally across all models
#2906
Comments
As long as |
Need to also make sure the form fields and serializer fields also have the correct max_length. |
Should revisit this aspect of our data models more generally - does |
Should consider |
name
field max_length
globally across all modelsmax_length
globally across all models
The scope will be any CharField under 255 will move to 255. |
Probably want a constant in nautobot.core |
Will want to doublecheck forms and serializer fields |
Implemented by #5355. |
Proposed Changes
The
max_length
field varies widley. Thisgrep
catches most of it (with uniqueness counts):Justification
This inconsistency causes recurring confusion in UX at a minimum, not to mention complicates testing and validation often enough to be a pain.
NB: This may be solved by the introduction of
BasePropertiesModel
or similar in #2822?TODO
name
'smax_length
to 255 #3171The text was updated successfully, but these errors were encountered: