Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase VLAN name's max_length to 255 #3171

Closed
Tracked by #2906
bryanculver opened this issue Jan 26, 2023 · 0 comments · Fixed by #3173
Closed
Tracked by #2906

Increase VLAN name's max_length to 255 #3171

bryanculver opened this issue Jan 26, 2023 · 0 comments · Fixed by #3173
Assignees
@glennmatthews
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v1.5.9

Comments

@bryanculver
Copy link
Member

bryanculver commented Jan 26, 2023 •
edited by glennmatthews
Loading

Platforms such as Junos allow for VLAN names up to 255 characters long (https://www.juniper.net/documentation/us/en/software/junos/multicast-l2/topics/ref/statement/vlans-bridging-qfx-series.html#vlans-statement__d38584e1038). We should support this.
@bryanculver bryanculver mentioned this issue Jan 26, 2023
Closed
2 tasks
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jan 26, 2023
@bryanculver bryanculver added this to the v1.5.9 milestone Jan 26, 2023
@glennmatthews glennmatthews self-assigned this Jan 26, 2023
glennmatthews added a commit that referenced this issue Jan 26, 2023
@glennmatthews
Fix #3171 - increase vlan.name max_length to 255
888c546
@glennmatthews glennmatthews mentioned this issue Jan 26, 2023
Merged
6 tasks
@bryanculver bryanculver mentioned this issue Jan 26, 2023
Merged
7 tasks
glennmatthews added a commit that referenced this issue Jan 26, 2023
@glennmatthews
Increase vlan.name max_length to 255 (#3173)
73766c9 
* Fix #3171 - increase vlan.name max_length to 255

* Update test data

* Add change note to docs

* Revert factory changes for now
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v1.5.9
Development

Successfully merging a pull request may close this issue.

Increase vlan.name max_length to 255 nautobot/nautobot
2 participants
@bryanculver @glennmatthews