Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ModelMultipleChoiceFilters to NaturalKeyOrPKMultipleChoiceFilter #3134

Closed
wants to merge 3 commits into from
Closed

Migrate ModelMultipleChoiceFilters to NaturalKeyOrPKMultipleChoiceFilter #3134

wants to merge 3 commits into from

Conversation

timizuoebideri1
Copy link
Contributor

…ultipleChoiceFilter and add deprecated warning to filter with _id suffix

Closes: #1916

What's Changed

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@timizuoebideri1
Replace django_filters.ModelMultipleChoiceFilter with NaturalKeyOrPKM…
a61b59e 
…ultipleChoiceFilter and add deprecated warning to filter with _id suffix
@timizuoebideri1 timizuoebideri1 linked an issue Jan 20, 2023 that may be closed by this pull request
Migrate ModelMultipleChoiceFilters to NaturalKeyOrPKMultipleChoiceFilter where possible #1916
Closed
@timizuoebideri1 timizuoebideri1 marked this pull request as draft January 20, 2023 10:51
@smk4664
Copy link
Contributor

smk4664 commented Jan 20, 2023

Since this is being done in a non-breaking way, can this be added to the next 1.5.x release?

@timizuoebideri1 timizuoebideri1 changed the base branch from next to develop January 24, 2023 04:28
@timizuoebideri1 timizuoebideri1 changed the base branch from develop to next January 24, 2023 04:28
@timizuoebideri1
Copy link
Contributor Author

Close in favour of #3150

@timizuoebideri1 timizuoebideri1 deleted the migrate_model_multiple_choice_fiilters branch August 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ModelMultipleChoiceFilters to NaturalKeyOrPKMultipleChoiceFilter where possible
2 participants
@timizuoebideri1 @smk4664