Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Release Github Action Workflow Doesn't Publish Python Version Specific Builds #3206

Closed
bryanculver opened this issue Jan 31, 2023 · 1 comment · Fixed by #3475
Closed

Pre-Release Github Action Workflow Doesn't Publish Python Version Specific Builds #3206

bryanculver opened this issue Jan 31, 2023 · 1 comment · Fixed by #3475
Assignees
@bryanculver
Labels
type: bug Something isn't working as expected type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

Environment

  • Nautobot version (Docker tag too if applicable): 2.0.0-alpha.1
  • Python version: 3.7-3.10
  • Database platform, version: NA
  • Middleware(s): NA

Steps to Reproduce

  1. Create Pre-Release Release named 2.0.0-alpha.1
  2. Wait for CI to Run

Expected Behavior

Docker containers built following or normal release convention 2.0.0-alpha.1 as well as 2.0.0-alpha.1-py3.10, 2.0.0-alpha.1-py3.9, etc.

Observed Behavior

Whichever container is published last "wins" and becomes the 2.0.0-alpha.1 build: https://hub.docker.com/layers/networktocode/nautobot/2.0.0-alpha.1/images/sha256-6f41c067abac092cbed73b5b6176f771e8432e6cbd380b8d5f9013ba521d87a6?context=explore
@bryanculver bryanculver added type: bug Something isn't working as expected type: housekeeping Changes to the application which do not directly impact the end user labels Jan 31, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Jan 31, 2023
@bryanculver
Copy link
Member Author

Should investigate maybe a couple other CI cleanups such as this resolved issue:

nautobot/.github/workflows/ci_integration.yml

Lines 178 to 181 in 1d5588f

- name: "Remove Installed Nautobots (Poetry Workaround)" # Workaround for https://github.com/python-poetry/poetry/issues/2918
run: "for i in $(ls -d1 ~/.cache/pypoetry/virtualenvs/*/lib/*/site-packages/nautobot-*.dist-info); do poetry run pip uninstall -y nautobot; done"
- name: "Reinstall Nautobot Local"
run: "poetry install"

bryanculver added a commit that referenced this issue Mar 23, 2023
@bryanculver
Fix #3206: Change prerelease label syntax.
a03347a
bryanculver added a commit that referenced this issue Mar 23, 2023
@bryanculver
Fix #3206: Change prerelease label syntax.
ac003c7
@bryanculver bryanculver mentioned this issue Mar 23, 2023
Merged
2 tasks
@bryanculver bryanculver self-assigned this Mar 23, 2023
glennmatthews pushed a commit that referenced this issue Mar 27, 2023
@bryanculver
Fix Docker Prerelease Tag Syntax (#3475)
226546b 
* Fix #3206: Change prerelease label syntax.

* Restore non-Python-version specific tag
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bryanculver bryanculver

Labels
type: bug Something isn't working as expected type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Fix Docker Prerelease Tag Syntax nautobot/nautobot
1 participant
@bryanculver