Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsetting/clearing a RelationshipAssociation while editing a model doesn't take effect. #325

Closed
glennmatthews opened this issue Apr 15, 2021 · 0 comments · Fixed by #329
Closed

Unsetting/clearing a RelationshipAssociation while editing a model doesn't take effect. #325

glennmatthews opened this issue Apr 15, 2021 · 0 comments · Fixed by #329
Assignees
@glennmatthews
Labels
type: bug Something isn't working as expected
Projects
Release v1.0.0
Milestone
v1.0.0

Comments

@glennmatthews
Copy link
Contributor

Environment

Steps to Reproduce

  1. Define a Relationship between models - for example a One-to-One relation between Device <--> IPAddress
  2. On an instance of Device, set an IPAddress for this relationship and save the model
  3. Confirm that the Device detail page correctly shows the defined relationship association
  4. Edit the Device again, clear the association form field (empty value) and save the model again
  5. The Device detail page still shows the defined relationship association

Expected Behavior

The relationship association should be removed.

Observed Behavior

The relationship association still exists.
@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Apr 15, 2021
@glennmatthews glennmatthews self-assigned this Apr 15, 2021
glennmatthews added a commit that referenced this issue Apr 15, 2021
@glennmatthews
Allow a RelationshipAssociation to be cleared when editing a relation…
6920ad3 
…ship model. Fixes #325
@jathanism jathanism added this to the v1.0.0 milestone Apr 16, 2021
@jathanism jathanism added this to To do in Release v1.0.0 via automation Apr 16, 2021
@glennmatthews glennmatthews mentioned this issue Apr 16, 2021
Merged
@paulbukauskas paulbukauskas moved this from To do to Review in progress in Release v1.0.0 Apr 19, 2021
Release v1.0.0 automation moved this from Review in progress to Done Apr 19, 2021
jathanism pushed a commit that referenced this issue Apr 19, 2021
@glennmatthews
Allow UI to unset a RelationshipAssociation (#329)
f0dc35e 
* Allow a RelationshipAssociation to be cleared when editing a relationship model. Fixes #325

* Add some view test coverage for RelationshipModel and CustomFieldModel classes

* Address review comment
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: bug Something isn't working as expected
Projects
No open projects
Release v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Allow UI to unset a RelationshipAssociation nautobot/nautobot
2 participants
@jathanism @glennmatthews