Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHook should provide old data together with new data #330

Closed
matt852 opened this issue Apr 16, 2021 · 3 comments · Fixed by #1389
Closed

WebHook should provide old data together with new data #330

matt852 opened this issue Apr 16, 2021 · 3 comments · Fixed by #1389
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone

Comments

@matt852
Copy link
Contributor

matt852 commented Apr 16, 2021

Environment

  • Python version: 3.6.8
  • Nautobot version: 1.0.0b3

Proposed Functionality

I'm submitting this feature request on behalf of @itdependsnetworks for webhooks to include old and new data (pre/post changes). There was an active issue with Netbox for this same issue, where the feature was recently merged in. It may be possible to reference this issue/PR and replicate the functionality in Nautobot.

netbox-community/netbox#3451
netbox-community/netbox@c6641ec

Use Case

An example use case from the linked issue above:
User creates Device/VM in Nautobot and assigns IP address with DNS Name --> DNS Name gets written into the DNS Server. User changes the DNS Name, old DNS Name gets deleted in the DNS and the new one created.

Database Changes

No

External Dependencies

None

@glennmatthews glennmatthews added status: under review type: feature Introduction of new or enhanced functionality to the application labels Apr 19, 2021
@glennmatthews glennmatthews added the impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release label Aug 5, 2021
@jedelman8
Copy link
Contributor

jedelman8 commented Aug 6, 2021

@glennmatthews does this need to be a breaking change? Can we only add a new key-value pair with the original/old data so receiving systems don't break? If so, we can move back to near-term.

@glennmatthews
Copy link
Contributor

Looking at the NetBox implementation, it was done as a new parallel set of key-value pairs, so if we follow that pattern, it should be reasonable.

@bryanculver
Copy link
Member

Merged into next.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Archived in project
6 participants