Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAddress: Addresss host modifiable, broadcast, prefix_length removal #3465

Closed
3 of 4 tasks
Tracked by #1673
, #1032
...
bryanculver opened this issue Mar 21, 2023 · 2 comments · Fixed by #3842
Closed
3 of 4 tasks
Tracked by #1673
, #1032
...

IPAddress: Addresss host modifiable, broadcast, prefix_length removal #3465

bryanculver opened this issue Mar 21, 2023 · 2 comments · Fixed by #3842
Assignees
@HanlinMiao
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

bryanculver commented Mar 21, 2023 •
edited by HanlinMiao
Loading

See #1673 for context.

Tasks
Beta Give feedback

Other:
Data migrations: #3681
Unit tests: #3688
@bryanculver bryanculver mentioned this issue Mar 21, 2023
Closed
14 tasks
@bryanculver bryanculver added the type: feature Introduction of new or enhanced functionality to the application label Mar 21, 2023
@bryanculver bryanculver changed the title Prefix-IPAddress Concrete Parenting: Beta-completeness Prefix-IPAddress Concrete Parenting: Feature-completeness Mar 21, 2023
@bryanculver bryanculver added the status: blocked Another issue or external requirement is preventing implementation label Mar 21, 2023
@bryanculver bryanculver mentioned this issue Mar 21, 2023
Closed
4 tasks
@bryanculver bryanculver added this to the v2.0.0 milestone Mar 21, 2023
@bryanculver bryanculver closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@bryanculver bryanculver reopened this May 3, 2023
@bryanculver bryanculver mentioned this issue May 3, 2023
Closed
6 tasks
@bryanculver bryanculver removed the status: blocked Another issue or external requirement is preventing implementation label May 3, 2023
@bryanculver bryanculver changed the title Prefix-IPAddress Concrete Parenting: Feature-completeness Prefix-IPAddress Concrete Parenting: Addresss host modifiable, broadcast, prefix_length removal May 3, 2023
@bryanculver bryanculver changed the title Prefix-IPAddress Concrete Parenting: Addresss host modifiable, broadcast, prefix_length removal IPAddress: Addresss host modifiable, broadcast, prefix_length removal May 3, 2023
@bryanculver
Copy link
Member Author

For 2.0.0: Must remove the fields above. host modifiable may be easy enough to enforce in the clean method for now, but not required for 2.0.0.

@HanlinMiao HanlinMiao self-assigned this May 22, 2023
HanlinMiao added a commit that referenced this issue Jun 2, 2023
@HanlinMiao
Merge branch 'prototype/jathanism-3337-ipam-namespace' of https://git…
0f501b8 
…hub.com/nautobot/nautobot into hanlin-#3465-remove-prefx-length-and-broadcast
@HanlinMiao HanlinMiao mentioned this issue Jun 2, 2023
Merged
7 tasks
@bryanculver bryanculver linked a pull request Jun 5, 2023 that will close this issue
Make IPAddress host non-modifiable, remove broadcast field and rename prefix_length field to mask_length field. #3842
Merged
7 tasks
@HanlinMiao
Copy link
Contributor

Closed by #3842

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HanlinMiao HanlinMiao

Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
2 participants
@bryanculver @HanlinMiao