Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0: Delaring Any Model with @extras_features("relationships") Empties Those from #826 #3592

Closed
bryanculver opened this issue Apr 14, 2023 · 1 comment · Fixed by #3594
Closed

2.0: Delaring Any Model with @extras_features("relationships") Empties Those from #826 #3592

bryanculver opened this issue Apr 14, 2023 · 1 comment · Fixed by #3594
Assignees
@bryanculver
Labels
type: bug Something isn't working as expected
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

Environment

  • Nautobot version (Docker tag too if applicable): next or v2.0.0-alpha.3
  • Python version: 3.X
  • Database platform, version: Any
  • Middleware(s): N/A

Same applies for Custom Fields.

Steps to Reproduce

  1. Clone the repo
  2. Add @extras_features("relationships") on any model inheriting from PrimaryModel
  3. Run Tests/Edit or Create a Relationship

Expected Behavior

Have access to all models that inherit from PrimaryModel to associate a Relationship to.

Observed Behavior

Only have the decorated model(s).
@bryanculver bryanculver added the type: bug Something isn't working as expected label Apr 14, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Apr 14, 2023
bryanculver added a commit that referenced this issue Apr 14, 2023
@bryanculver
Fix #3592: Better duplicate call detection for populate_model_feature…
de76c3a 
…s_registry()
@bryanculver bryanculver mentioned this issue Apr 14, 2023
Merged
5 tasks
@bryanculver bryanculver self-assigned this Apr 17, 2023
@bryanculver bryanculver linked a pull request Apr 17, 2023 that will close this issue
Fix #3592: Better duplicate call detection for populate_model_features_registry() #3594
Merged
5 tasks
bryanculver added a commit that referenced this issue Apr 17, 2023
@bryanculver @glennmatthews
Fix #3592: Better duplicate call detection for populate_model_feature…
f0ac43a 
…s_registry() (#3594)

* Fix #3592: Better duplicate call detection for populate_model_features_registry()

* Fix copy paste fail.

* Update nautobot/extras/utils.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Add test for noop, refresh of model features registry.

* Less mucking with the registry

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@bryanculver
Copy link
Member Author

Closed with #3594

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bryanculver bryanculver

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Fix #3592: Better duplicate call detection for populate_model_features_registry() nautobot/nautobot
1 participant
@bryanculver