Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pk as default lookup_field for NautobotUIViewSet #3607

Merged
merged 9 commits into from
Apr 21, 2023
Merged

use pk as default lookup_field for NautobotUIViewSet #3607

merged 9 commits into from
Apr 21, 2023

Conversation

timizuoebideri1
Copy link
Contributor

Closes: #3497

What's Changed

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@timizuoebideri1 timizuoebideri1 changed the title use Pk instead of slug in NautobotUIViewSet. lookup_field use pk as default lookup_field for NautobotUIViewSet Apr 18, 2023
@bryanculver bryanculver linked an issue Apr 18, 2023 that may be closed by this pull request
Update lookup_field in NautobotUIViewSet to pk #3497
Closed
glennmatthews
glennmatthews requested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's text in nautobot/docs/plugins/development.md about lookup_field that needs to be updated appropriately for this change.

changes/3607.removed Outdated Show resolved Hide resolved
timizuoebideri1 and others added 2 commits April 18, 2023 14:20
@timizuoebideri1 @glennmatthews
Update changes/3607.removed
df3d4f5 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@timizuoebideri1
Update docs
1eebdb1
@timizuoebideri1 @glennmatthews
Update nautobot/docs/plugins/development.md
f8184dc 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
glennmatthews reviewed Apr 20, 2023
View reviewed changes
changes/3607.removed Outdated Show resolved Hide resolved
@bryanculver bryanculver merged commit 9a699d4 into next Apr 21, 2023
@bryanculver bryanculver deleted the u/timizuoebideri-3497-update_lookup_field branch April 21, 2023 17:09
@bryanculver bryanculver mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver left review comments

@jathanism jathanism jathanism approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update lookup_field in NautobotUIViewSet to pk
4 participants
@timizuoebideri1 @bryanculver @jathanism @glennmatthews