Apply Custom Validators without the need of a DB lookup for ContentType #3633
Conversation
| for app_label, models in FeatureQuery("custom_validators").get_dict(): | ||
| for model in models: | ||
| model_class = apps.get_model(app_label=app_label, model_name=model) | ||
| model_class.clean = custom_validator_clean(model_class.clean) |
There was a problem hiding this comment.
I assume in this case we don't need the ContentType for some FK lookup in the DB but we just need to wrap the class' clean method, probably better to go straight to the Django for that. Cut out the middle man I think.
|
Brilliant! |
| model_class.clean = custom_validator_clean(model_class.clean) | ||
| for app_label, models in FeatureQuery("custom_validators").get_dict(): | ||
| for model in models: | ||
| model_class = apps.get_model(app_label=app_label, model_name=model) |
There was a problem hiding this comment.
Possibly might need/want the wrap_model_clean_methods function to take an apps parameter (defaulting to the global apps) so that for example we could call this function during a migration or a nautobot_database_ready signal handler where apps is a different context? Not sure, just thinking aloud.
There was a problem hiding this comment.
@glennmatthews your thought is so if a custom validator is available we can use it in migrations now? Because I assume that doesn't work at present?
There was a problem hiding this comment.
Yeah, seems pretty clear it wouldn't work at present. We probably don't want them to apply during migrations in general (that would be troublesome) but I feel like there might be a use case for having them apply during the database-ready callback signals? As I said, not sure. :-)
There was a problem hiding this comment.
Required for this PR or future housekeeping/feature?
There was a problem hiding this comment.
Definitely not required.
nautobot/extras/utils.py
Outdated
| query |= Q(app_label=app_label, model__in=models) | ||
|
|
||
| return query | ||
|
|
||
| def get_dict(self): |
There was a problem hiding this comment.
Maybe items or as_dict instead? Not blocking.
bryanculver
deleted the
u/bryanculver-wrap-custom-validators-without-query
branch
Closes: #DNE
What's Changed
Observing the need for this: https://github.com/nautobot/nautobot/pull/3614/files#diff-cca2a364f59877c49898f8d14d311f7567adfb80b5aec6fa51748be4f79ef9b5R44-R46
This might be one of the weird DB calls we see on startup pre-fork in Celery 🤷
TODO