Incorrect GraphQL tooltip when filtering cables by site

[matt852]

Environment

• Python version: 3.8.5
• Nautobot version: v1.0.0b5

This bug was introduced with the fix from PR #360. When querying for cables and filtering by site, the tooltip should say something like:

site: [String] [Slug]

However the tooltip actually says

site: [String] [invalid name]

Steps to Reproduce

1. In the latest develop branch, open GraphQL in the UI
2. Run a query on cables, like below, and hover over "site"

{
    cables(site: "<site-slug>") {
        id
    }
}

Expected Behavior

The tooltip for "site" should state that the slug is needed

Observed Behavior

The tooltip for "site" shows an "invalid name"

[jathanism]

So we did a little digging and it turns out that for any filterset field that is a method field (such as CableFilterSet.site) a label must also be set, or the text will come back as [invalid name].

Fortunately it appears there aren't a huge amount of them:

$ egrep -r '= .*Filter\(method' nautobot | grep -v label                                      <<<
nautobot/dcim/filters.py:    device_id = MultiValueCharFilter(method="filter_device")
nautobot/dcim/filters.py:    device = MultiValueCharFilter(method="filter_device", field_name="device__name")
nautobot/dcim/filters.py:    rack_id = MultiValueCharFilter(method="filter_device", field_name="device__rack_id")
nautobot/dcim/filters.py:    rack = MultiValueCharFilter(method="filter_device", field_name="device__rack__name")
nautobot/dcim/filters.py:    site_id = MultiValueCharFilter(method="filter_device", field_name="device__site_id")
nautobot/dcim/filters.py:    site = MultiValueCharFilter(method="filter_device", field_name="device__site__slug")
nautobot/dcim/filters.py:    tenant_id = MultiValueCharFilter(method="filter_device", field_name="device__tenant_id")
nautobot/dcim/filters.py:    tenant = MultiValueCharFilter(method="filter_device", field_name="device__tenant__slug")
nautobot/dcim/filters.py:    device_id = MultiValueCharFilter(method="filter_device")
nautobot/dcim/filters.py:    device = MultiValueCharFilter(method="filter_device", field_name="device__name")
nautobot/dcim/filters.py:    device_id = MultiValueCharFilter(method="filter_device")
nautobot/dcim/filters.py:    device = MultiValueCharFilter(method="filter_device", field_name="device__name")
nautobot/dcim/filters.py:    device_id = MultiValueCharFilter(method="filter_device")
nautobot/dcim/filters.py:    device = MultiValueCharFilter(method="filter_device", field_name="device__name")