[REVIEW] Next UI Hackathon #3651

bryanculver · 2023-04-25T19:08:50Z

- Generic create view is now working againn and will correctly redirect on create - `uiSchema` is now being enforced on Form compponents for create view - API endpoints no longer include `serializer/formData` keys and is back to the default endpoint responses from v1 - `schema/uiSchema keys now emit on `OPTIONS` queries only - This is currently a POC hack. The correct solution should replace the metadata class and not overload `finalize_response()` on the viewsets. - A number of extra `FIXME` comments put into place circle back to for correctness.

…ext-ui

- Only the Metadata class emits JSON schema now when an `OPTIONS` request is made - Legacy `NautobotMetadata` renamed to `NautobotMetadataV1` for now - All other code that was in `nautobot.core.api.views` has been ripped out and there is no longer a need to overload or modify anything with REST API views - Made `eslint` happy

- Caveat: `ImageField` of type "image" is not happy from `@rjsf/core` and reports it as "Unsupported schema type"; so it is hard-coded as "string" type for the moment.

…ext-ui

* Restructure nav menu * Change nav menu API return, update context when switching object list views, only show menu for current context * Prettier and lint * Get sub-group menus working * ESLint --------- Co-authored-by: Bryan Culver <me@bryanculver.com>

…ext-ui

…cts with depth 0 (#3679) * Change API to use HyperlinkedModelSerializer * flake8 failure that crept in during merge * pylint ftw * Test fix and change fragments * Update return_nested_serializer_data_based_on_depth to use URLs instead of PKs with depth 0 * Make an attempt at updating the REST API docs - definitely not comprehensive * Address review feedback

gsnider2195 · 2023-05-04T14:58:50Z

nautobot/core/apps/__init__.py

+        # TODO: allow for recursive (more than two-level) nesting of groups?
+        for group in nav_tab.groups:
+            if not isinstance(group, NavMenuGroup):
+                raise TypeError(f"Expected a NavMenuGroup, but got {group}")


Suggested change

raise TypeError(f"Expected a NavMenuGroup, but got {group}")

raise TypeError(f"Expected a NavMenuGroup, but got {type(group)}")

gsnider2195 · 2023-05-04T14:59:33Z

nautobot/core/apps/__init__.py

-                        f"{nav_tab.name} -> {group.name} -> {item.link}",
-                    )
+        if not isinstance(nav_tab, NavMenuTab):
+            raise TypeError(f"Top level objects need to be an instance of NavMenuTab: {nav_tab}")


Suggested change

raise TypeError(f"Top level objects need to be an instance of NavMenuTab: {nav_tab}")

raise TypeError(f"Expected a NavMenuTab, but got {type(nav_tab)}")

gsnider2195 · 2023-05-04T15:00:10Z

nautobot/core/apps/__init__.py

+            group_perms = registry_groups[group.name]["permissions"]
+            for item in group.items:
+                if not isinstance(item, (NavMenuGroup, NavMenuItem)):
+                    raise TypeError(f"Expected NavMenuItem or NavMenuGroup, but found {item}")


Suggested change

raise TypeError(f"Expected NavMenuItem or NavMenuGroup, but found {item}")

raise TypeError(f"Expected NavMenuItem or NavMenuGroup, but got {type(item)}")

…le width

gsnider2195 · 2023-05-04T20:58:21Z

nautobot/dcim/tests/test_api.py


-        master_device = Device.objects.get(pk=virtual_chassis_1["master"])
+        # The `master` key will be a URL now, but it contains the PK
+        master_device = Device.objects.get(pk=virtual_chassis_1["master"].split("/")[-2])


TODO: helper function to extract a pk from an api url or even return the instance of the object?

* Implemented list_display_fields for IPAM serializers. * Renamed `Meta.list_display` to `list_display_fields` for improved readability. * Fixed a bug in UI `ObjectCreate` where uiSchema was `undefined`. * Enable OPTIONS in the browsable API. * Updated `WritableSerializerMixin` to support URLs as pk * Introduced new `is_url()` helper that uses Django's `URLValidator` under the hood. * PK will be extracted from the URL before passed onto PK validation. * Reverted a change to `readOnly` and `format` JSON schema hints that was breaking validation * Fix a bug in getting the list display fields. * bump for nautobot-ui * add default headers to dcim and tenancy * fix react warning * fix initial column state * add support for boolean table items --------- Co-authored-by: Bryan Culver <bryan.culver@networktocode.com> Co-authored-by: Gary Snider <gary.snider@networktocode.com>

bryanculver · 2023-05-08T20:23:51Z

nautobot/core/api/mixins.py

@@ -62,6 +63,12 @@ def get_queryset_filter_params(self, data, queryset):
        if isinstance(data, dict):
            params = dict_to_filter_params(data)
            return self.remove_non_filter_fields(params)
+
+        # Account for the fact that HyperlinkedIdentityFields might pass in URLs.


TODO: Let's account for this in the docstrings

bryanculver · 2023-05-08T20:35:14Z

nautobot/core/settings.py

+    # "NautobotHyperlinkedRelatedField": {"type": "string", "readOnly": True},
+    # type=string results in a free text field; also not what we want. For now,
+    # however, this will keep things moving so the unit tests pass.
+    "NautobotHyperlinkedRelatedField": {"type": "string", "format": "uuid"},


TODO: Should this be "format": "url"?

Looks like it would be uri but we should probably hold off on making any changes that assume we're going to keep using rjsf

It can be a UUID on write.

glennmatthews

Let's merge and iterate!

Hanlin Miao and others added 30 commits April 25, 2023 14:21

detail view is able to render

48cf50d

Add storybook container

c117cda

Run CI on commit of next-ui. Style and lint

f4ea611

handle value rendering when it is a list and when it has a web url

77608c4

Merge branch 'next-ui' of https://github.com/nautobot/nautobot into n…

e5ab3ce

…ext-ui

Prettier and lint

34f6fe4

Merge remote-tracking branch 'upstream/next-ui' into next-ui

12fd5f0

set redux cache timeout to 5 seconds

785c75d

fix button padding

a9a8220

Added remaining field type mappings for JSON schema

8415285

- Caveat: `ImageField` of type "image" is not happy from `@rjsf/core` and reports it as "Unsupported schema type"; so it is hard-coded as "string" type for the moment.

Merge remote-tracking branch 'upstream/next-ui' into next-ui

100aecb

notes tab and changelog tab render correctly for some ...

293cb3c

Merge branch 'next-ui' of https://github.com/nautobot/nautobot into n…

b50067f

…ext-ui

update list view title / buttons

5fa93a0

Merge branch 'next-ui' of github.com:nautobot/nautobot into next-ui

be6d5cc

Less swr

a1bb883

Nav menu revisions WIP (#3652)

8d34946

* Restructure nav menu * Change nav menu API return, update context when switching object list views, only show menu for current context * Prettier and lint * Get sub-group menus working * ESLint --------- Co-authored-by: Bryan Culver <me@bryanculver.com>

Flatten components directory

e61110f

Fix paths from flattening

37630fc

Missed import, hide scroll

ed076e9

Fix warning about changed weight

227e687

Highlight active icon based on appContext

1fd37e6

Fix minor issue with breadcrumb menus

b4abd52

Really fix weight issue

47240b1

ESLint

face64e

Fix some tests

6e706e0

Update some docstrings and behavior

dbacee1

Add change fragment, update docs, remove invalid template

b1bc29b

Hanlin Miao and others added 9 commits May 3, 2023 15:02

Merge branch 'next-ui' of https://github.com/nautobot/nautobot into n…

8d32fa7

…ext-ui

Remove web_url

8768ccf

Fix redirect after object create

2f8cc12

more login improvements

2b1198d

Merge branch 'next-ui' of github.com:nautobot/nautobot into next-ui

f21d7f0

Fix missing breadcrumb on ObjectRetrieve

51158eb

Fix a few react complaints

8790619

Remove redundant favicon file

8492daf

glennmatthews mentioned this pull request May 3, 2023

2.0 Housekeeping: Extras #2857

Open

gsnider2195 added 2 commits May 4, 2023 08:39

use title case on object list skeleton

a1fa2d3

change GetMenuAPIView to only work for authenticated users

eb51b49

gsnider2195 reviewed May 4, 2023

View reviewed changes

enhanced the ObjectListView loading skeleton and fixed? ObjectListTab…

93045f0

…le width

gsnider2195 reviewed May 4, 2023

View reviewed changes

final polish on detail view

67be074

glennmatthews mentioned this pull request May 5, 2023

Data source integration for v2 nautobot/pylint-nautobot#7

Merged

jathanism and others added 2 commits May 8, 2023 15:07

remove unused prototype code

53ba145

bryanculver commented May 8, 2023

View reviewed changes

glennmatthews approved these changes May 8, 2023

View reviewed changes

bryanculver merged commit 74487a0 into next May 9, 2023

bryanculver deleted the next-ui branch May 9, 2023 02:52

bryanculver mentioned this pull request May 9, 2023

UI Overhaul: Sprint 50 Hackathon #3691

Closed

glennmatthews mentioned this pull request May 10, 2023

RESTful API self-consistent data types regardless of depth #3725

Closed

bryanculver mentioned this pull request May 22, 2023

UI 2.0: Update Nav Menu for Context-Centered Navigation #3527

Closed

glennmatthews mentioned this pull request Jun 22, 2023

Reintroduce Legacy Navigation #3964

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REVIEW] Next UI Hackathon #3651

[REVIEW] Next UI Hackathon #3651

bryanculver commented Apr 25, 2023 •

edited

Loading

gsnider2195 May 4, 2023

gsnider2195 May 4, 2023

gsnider2195 May 4, 2023

gsnider2195 May 4, 2023

bryanculver May 8, 2023

bryanculver May 8, 2023

gsnider2195 May 8, 2023

glennmatthews May 8, 2023

glennmatthews left a comment

	raise TypeError(f"Expected a NavMenuGroup, but got {group}")
	raise TypeError(f"Expected a NavMenuGroup, but got {type(group)}")

	raise TypeError(f"Top level objects need to be an instance of NavMenuTab: {nav_tab}")
	raise TypeError(f"Expected a NavMenuTab, but got {type(nav_tab)}")

	raise TypeError(f"Expected NavMenuItem or NavMenuGroup, but found {item}")
	raise TypeError(f"Expected NavMenuItem or NavMenuGroup, but got {type(item)}")

[REVIEW] Next UI Hackathon #3651

[REVIEW] Next UI Hackathon #3651

Conversation

bryanculver commented Apr 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glennmatthews left a comment

Choose a reason for hiding this comment

bryanculver commented Apr 25, 2023 •

edited

Loading