Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ScheduledJob Uniqueness Constraint #3847

Closed
bryanculver opened this issue Jun 3, 2023 · 1 comment · Fixed by #3871
Closed

Change ScheduledJob Uniqueness Constraint #3847

bryanculver opened this issue Jun 3, 2023 · 1 comment · Fixed by #3871
Assignees
@glennmatthews
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@bryanculver
Copy link
Member

bryanculver commented Jun 3, 2023 •
edited

Carved from #2908

Proposed Changes

Make name unique, enumerate if duplicate, update help text and auto-assign name (the uuid) for one-off jobs
@bryanculver bryanculver added type: housekeeping Changes to the application which do not directly impact the end user impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release labels Jun 3, 2023
@bryanculver bryanculver added this to the v2.0.0 milestone Jun 3, 2023
@bryanculver bryanculver mentioned this issue Jun 3, 2023
Closed
@glennmatthews glennmatthews self-assigned this Jun 6, 2023
glennmatthews added a commit that referenced this issue Jun 7, 2023
@glennmatthews
Fix #3847, #3848, and #3849 - extras uniqueness changes
8f42513
@glennmatthews glennmatthews mentioned this issue Jun 7, 2023
Merged
6 tasks
@glennmatthews glennmatthews linked a pull request Jun 7, 2023 that will close this issue
Fix #3847, #3848, and #3849 - extras uniqueness changes #3871
Merged
6 tasks
HanlinMiao added a commit that referenced this issue Jun 8, 2023
@glennmatthews @HanlinMiao
Fix #3847, #3848, and #3849 - extras uniqueness changes (#3871)
7197b3a 
* Fix #3847, #3848, and #3849 - extras uniqueness changes

* Test fixes

* Another test fix

* Update migration tables

* use check_for_duplicates_with_natural_key_fields_in_migration helper method in migration file

* remove unused imports

---------

Co-authored-by: Hanlin Miao <hanlin980505@gmail.com>
@HanlinMiao
Copy link
Contributor

Closed by #3871

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Fix #3847, #3848, and #3849 - extras uniqueness changes nautobot/nautobot
3 participants
@bryanculver @glennmatthews @HanlinMiao