Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 IPAM Overhaul: Add constraints to Prefix.parent #3935

Closed
11 tasks
Tracked by #1032
gsnider2195 opened this issue Jun 16, 2023 · 1 comment · Fixed by #3942
Closed
11 tasks
Tracked by #1032

2.0 IPAM Overhaul: Add constraints to Prefix.parent #3935

gsnider2195 opened this issue Jun 16, 2023 · 1 comment · Fixed by #3942
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone

Comments

@gsnider2195
Copy link
Contributor

gsnider2195 commented Jun 16, 2023

  • Prefix type network can only contain IP addresses and prefix of type pool
  • Prefix type container can only contain child prefixes of type container or network
  • Prefix type is user serviceable and defaults to Container
  • Bring back the is_pool property
  • IP Address parent property cannot be set to a prefix with type pool, it will parent to the nearest network prefix
  • Pools cannot contain child prefixes or ip addresses

This is going to require us to revisit the IPAM data migrations for prefix/ip address parenting

TODO: UX fixes

Prefix save/delete methods

  • Network contains IP addresses but we want to subdivide the network (/24 converted to /25)
    • Newly created prefix will contain all of the parent prefix's IP addresses, parent will be converted to a container automatically
    • Newly created prefix will NOT contain all of the parent prefix's IP addresses. Do we fail on creation of the new prefix?
  • Network contains IP addresses but we want to delete the network and reparent all of the IPs to the parent (/25 converted to /24)

IP Address save method

  • IP Address created in a container prefix that does not contain any prefixes. Does the creation of the IP address automatically convert the parent container to a network?
@gsnider2195 gsnider2195 mentioned this issue Jun 16, 2023
6 tasks
@gsnider2195 gsnider2195 changed the title Add constraints to Prefix.parent 2.0 IPAM Overhaul: Add constraints to Prefix.parent Jun 16, 2023
@gsnider2195 gsnider2195 self-assigned this Jun 16, 2023
@gsnider2195 gsnider2195 added this to the v2.0.0 milestone Jun 16, 2023
@bryanculver bryanculver added the type: feature Introduction of new or enhanced functionality to the application label Jun 26, 2023
@gsnider2195 gsnider2195 linked a pull request Jun 29, 2023 that will close this issue
7 tasks
@gsnider2195
Copy link
Contributor Author

Completed by #3942

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants