Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAM 2.0: Revisit prefix/ipaddress type constraints #4004

Closed
gsnider2195 opened this issue Jun 27, 2023 · 2 comments · Fixed by #4036
Closed

IPAM 2.0: Revisit prefix/ipaddress type constraints #4004

gsnider2195 opened this issue Jun 27, 2023 · 2 comments · Fixed by #4036
Assignees
@glennmatthews
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone
v2.0.0

Comments

@gsnider2195
Copy link
Contributor

Proposed Changes

Migrations need to be updated to account for the prefix/ip address type constraints added in #3935:

  • nautobot/ipam/migrations/0031_ipam___data_migrations.py

Justification

Follow-up work from #3935
@gsnider2195 gsnider2195 mentioned this issue Jun 27, 2023
Merged
7 tasks
@glennmatthews glennmatthews self-assigned this Jun 29, 2023
@glennmatthews glennmatthews added this to the v2.0.0 milestone Jun 29, 2023
@glennmatthews glennmatthews changed the title IPAM 2.0: Revisit prefix/ipaddress migrations to account for parent type constraints IPAM 2.0: Revisit prefix/ipaddress type constraints Jun 29, 2023
@glennmatthews
Copy link
Contributor

glennmatthews commented Jun 29, 2023 •
edited
Loading

Per discussion within the team, we'll be changing the constraints from #3942 to be "advisory" rather than strictly enforced in 2.0. This will give time for users to clean up their data during 2.x and we can enforce these constraints in 3.0.

@glennmatthews glennmatthews added the type: feature Introduction of new or enhanced functionality to the application label Jun 29, 2023
@glennmatthews glennmatthews mentioned this issue Jun 30, 2023
Merged
6 tasks
@glennmatthews glennmatthews linked a pull request Jun 30, 2023 that will close this issue
Change prefix type enforcement to advisory for 2.0 #4036
Merged
6 tasks
@glennmatthews
Copy link
Contributor

implemented by #4036.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Change prefix type enforcement to advisory for 2.0 nautobot/nautobot
2 participants
@glennmatthews @gsnider2195