Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Release, Prerelease Workflow Container Images #4029

Open
Tracked by #4191
bryanculver opened this issue Jun 29, 2023 · 4 comments
Open
Tracked by #4191

Change Release, Prerelease Workflow Container Images #4029

bryanculver opened this issue Jun 29, 2023 · 4 comments
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@bryanculver
Copy link
Member

bryanculver commented Jun 29, 2023

Proposed Changes

Change the containers we build and publish in next and develop.

  • nautobot-dev (layer final-dev): Publish min and max supported Python versions
    • 3.7,3.11 for develop
    • 3.8,3.11 for next
  • nautobot (layer final): Build and Publish only max supported Python version
    • This would drop publishing earlier Python version images (even if still supported)
    • Keep 1.5.X as-is: Publish the same matrix of Python versions
    • 1.6.0+: Publish only the max version (3.11 as of writing this)
  • Change POETRY_PARALLEL to be True in the release workflows

Plugins will still be able to use "branch version" images for CI testing and developing locally.

Justification

  • Speed up CI integration runtimes (frequently times out, uses many runners)
  • Improve our Actions cache utilization (fit more within cache with fewer evictions and speed up rebuilds)
  • Many cases of deployers rolling their own Docker image anyway
  • Publishing max vs publishing min Python version for nautobot image: Many apps have a higher lower bound due to their direct dependencies but Nautobot is slower to adopt a newer upper bound for stability reasons.
@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Jun 29, 2023
@glennmatthews
Copy link
Contributor

This should include enabling Python 3.11 in both develop-1.6 and next, IMHO.

@glennmatthews
Copy link
Contributor

Actually it looks like updating to support 3.11 requires some dependency updates; I'll handle that in a separate PR.

@glennmatthews
Copy link
Contributor

#4118 for develop-1.6.

@snaselj
Copy link
Contributor

snaselj commented Aug 2, 2023

Fix if conditions not to be string:

.github/workflows/prerelease.yml
153: if: "${{ env.SLACK_WEBHOOK_URL != '' }}"

.github/workflows/release.yml
159: if: "${{ env.SLACK_WEBHOOK_URL != '' }}"

@jathanism jathanism mentioned this issue Aug 2, 2023
4 tasks
bryanculver added a commit that referenced this issue Aug 2, 2023
jathanism added a commit that referenced this issue Aug 2, 2023
…4196)

* Bump version to 1.6-rc.1 and build release notes for develop-1.6.
* Address commited details of #4029

---------

Co-authored-by: Bryan Culver <bryan.culver@networktocode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Status: To Groom
Status: In Progress
Development

No branches or pull requests

3 participants