-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invoke markdownlint
does not run in the docker environment
#4061
Labels
type: bug
Something isn't working as expected
Comments
Thanks for filing this Gary! I've noticed the same symptom. |
glennmatthews
added a commit
that referenced
this issue
Jul 10, 2023
Dockerfile and Docker Compose changes: - Split python and node installation and compilation into separate parallel build stages - Add cache mounts for `apt` to hopefully improve rebuild performance - Change `dev` and `final-dev` targets to install to `/opt/nautobot` virtualenv and run as the `nautobot` user - Build Nautobot 2.0 UI as part of Docker image build - `nodejs` container now uses the nautobot `dev` image instead of pulling `node` image - Removed `node_modules` shared volume between `nautobot` and `nodejs` containers as no longer needed Other changes: - Fix tasks.py definition for `invoke markdownlint` in docker workflow (fixes #4061) - Update installed Poetry version to 1.5.1 - Update `markdownlint` to 0.35.0 and fix some new warnings it raises - Remove separate package.json for markdownlint/eslint/prettier, roll them into the main package.json
5 tasks
5 tasks
glennmatthews
added a commit
that referenced
this issue
Jul 13, 2023
* Refactor Dockerfile, fix #4061, etc. Dockerfile and Docker Compose changes: - Split python and node installation and compilation into separate parallel build stages - Add cache mounts for `apt` to hopefully improve rebuild performance - Change `dev` and `final-dev` targets to install to `/opt/nautobot` virtualenv and run as the `nautobot` user - Build Nautobot 2.0 UI as part of Docker image build - `nodejs` container now uses the nautobot `dev` image instead of pulling `node` image - Removed `node_modules` shared volume between `nautobot` and `nodejs` containers as no longer needed Other changes: - Fix tasks.py definition for `invoke markdownlint` in docker workflow (fixes #4061) - Update installed Poetry version to 1.5.1 - Update `markdownlint` to 0.35.0 and fix some new warnings it raises - Remove separate package.json for markdownlint/eslint/prettier, roll them into the main package.json * More markdownlint fixes * Make a stab at fixing tasks and PR CI * NPM/linting updates here too * Add temporary build stage for PRs * Simplify test docker tags * Lock cache mounts to avoid problems with parallel builds * Add generated files to .dockerignore, remove apt cache mounts, rework Dockerfile * Black/flake8 * Remove temporary build
Fixed by #4082. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Environment
Steps to Reproduce
invoke markdownlint
in the docker dev environmentExpected Behavior
Markdownlint runs
Observed Behavior
The command errors out with:
The contents of the log:
The npm dependencies are installed in
/source/
in the dockerfiledependencies-dev
stage but:/source/
is overwritten/source/
gets bound from the host filesystem so anything that was in that directory in the container image is lostWorkaround until the bug is fixed:
inv cli
npm install
from within the container will install the dependencies to the locally bound filesystemThe text was updated successfully, but these errors were encountered: