Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing libxmlsec1-openssl package in Docker image #4093

Closed
jakubkrysl opened this issue Jul 11, 2023 · 7 comments · Fixed by #4282
Closed

Missing libxmlsec1-openssl package in Docker image #4093

jakubkrysl opened this issue Jul 11, 2023 · 7 comments · Fixed by #4282
Assignees
Labels
type: bug Something isn't working as expected

Comments

@jakubkrysl
Copy link

Environment

  • Nautobot version (Docker tag too if applicable): 1.5.19-py3.10
  • Python version: 3.10.11
  • Database platform, version:
  • Middleware(s):

Steps to Reproduce

  1. enable SAML SSO
  2. startup Nautobot from Docker image

Note: all Python packages for SSO are installed, this one is missing from system and should be installed too
Workaround: apt-get install libxmlsec1-openssl in the running container

Expected Behavior

Nautobot started

Observed Behavior

image

@bryanculver bryanculver added the type: bug Something isn't working as expected label Jul 11, 2023
@glennmatthews
Copy link
Contributor

So we do install libxmlsec1-openssl in the Docker build, but only as part of the dependencies build stage, and don't do anything to copy it to the final image (which doesn't directly inherit from dependencies. It may be that just moving libxmlsec1-openssl from https://github.com/nautobot/nautobot/blob/develop/docker/Dockerfile#L129 to https://github.com/nautobot/nautobot/blob/develop/docker/Dockerfile#L106 is needed.

@glennmatthews
Copy link
Contributor

Is this a new issue in the 1.5.19 image (i.e. a regression) or has this never worked as intended?

@glennmatthews glennmatthews added the question Further information is requested label Jul 13, 2023
@jakubkrysl
Copy link
Author

Is this a new issue in the 1.5.19 image (i.e. a regression) or has this never worked as intended?

I don't know. We only just started implementing SSO, so I did not try any other images. Want me to try our config on some older images locally? Any particular versions you have in mind?

@glennmatthews
Copy link
Contributor

glennmatthews commented Jul 13, 2023

Thanks for the offer! We haven't changed how we install system packages in the Docker build in quite some time so I suspect it's a long-standing issue - possibly as far back as v1.3 and #1620.

(edit) I won't ask you to try and go that far back though! :-)

@bryanculver bryanculver removed the question Further information is requested label Aug 7, 2023
@jakubkrysl
Copy link
Author

jakubkrysl commented Aug 14, 2023

Thanks for the offer! We haven't changed how we install system packages in the Docker build in quite some time so I suspect it's a long-standing issue - possibly as far back as v1.3 and #1620.

(edit) I won't ask you to try and go that far back though! :-)

Hi,
Sorry it took me so long, I did not have the time to get to it :/
I tried following previous versions, all showed the package is missing and installing the package to the container fixed the error.

  • 1.5.2
  • 1.4.7
  • 1.3.0

I tried even 1.2.0, but could not get it running due to changes to webserver.

@glennmatthews
Copy link
Contributor

Thank you for going above and beyond! We'll get this fixed.

@bryanculver
Copy link
Member

@gsnider2195 gsnider2195 self-assigned this Aug 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants