Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Check Secret" button on Secrets page is broken #4127

Closed
JostLuebbe opened this issue Jul 17, 2023 · 0 comments · Fixed by #4139
Closed

"Check Secret" button on Secrets page is broken #4127

JostLuebbe opened this issue Jul 17, 2023 · 0 comments · Fixed by #4139
Assignees
@glennmatthews
Labels
type: bug Something isn't working as expected

Comments

@JostLuebbe
Copy link

Environment

  • Nautobot version (Docker tag too if applicable): 1.5.23
  • Python version: 3.10
  • Database platform, version: postgresql, 13.10
  • Middleware(s): N/A

Steps to Reproduce

  1. Create a secret.
  2. Go to that secret's page.
  3. Press the "Check Secret" button in the top right.

Expected Behavior

I expected to see a popup with a status message of either "The secret was successfully retrieved." or "Error retrieving secret: ...".

Observed Behavior

No popup is created and the following error messages are generated in the console:

  • Upon loading the page:
    Uncaught SyntaxError: expected expression, got '<'
  • Upon pressing the button:
    Uncaught ReferenceError: checkSecret is not defined

Likely Cause

PR#4048 added {{ block.super }} inside of a script tag, causing it to be nested and generate these errors. Moving this import outside of the script tag should make it work again.
@JostLuebbe JostLuebbe mentioned this issue Jul 17, 2023
Merged
7 tasks
@glennmatthews glennmatthews added the type: bug Something isn't working as expected label Jul 17, 2023
@glennmatthews glennmatthews added this to the v1.6.0 milestone Jul 17, 2023
@glennmatthews glennmatthews self-assigned this Jul 18, 2023
glennmatthews added a commit that referenced this issue Jul 18, 2023
@glennmatthews
Fix #4127
07ff570
@glennmatthews glennmatthews mentioned this issue Jul 18, 2023
Merged
4 tasks
@glennmatthews glennmatthews removed this from the v1.6.0 milestone Jul 18, 2023
glennmatthews added a commit that referenced this issue Jul 19, 2023
@glennmatthews
Fix #4127 (#4139)
0c48d1e
itdependsnetworks pushed a commit to itdependsnetworks/nautobot that referenced this issue Jul 28, 2023
@glennmatthews @itdependsnetworks
Fix nautobot#4127 (nautobot#4139)
3a535ee
HanlinMiao added a commit that referenced this issue Aug 1, 2023
@grelleum @HanlinMiao
@dependabot @glennmatthews @Kircheneer
Interface redundancy groups (#4177)
cb1df3c 
* cherry-picked InterfaceRedundancyGroup changes

* flake8

* flake8

* tests

* check-schema tests

* Bump cryptography from 41.0.0 to 41.0.2 (#4126)

* Bump cryptography from 41.0.0 to 41.0.2

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.0 to 41.0.2.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.0...41.0.2)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Change fragment

* Monday brain

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Fixed custom fields not auto-populating when creating objects through… (#4123)

* Fixed custom fields not auto-populating when creating objects through the ORM.

* Fix change fragment name

* Add more testing and move to CustomFieldModelTest

* Update nautobot/extras/tests/test_customfields.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Update nautobot/extras/tests/test_customfields.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Update nautobot/extras/tests/test_customfields.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Fix unit tests§

* Sort imports.

* Update docs.

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Fix #4127 (#4139)

* Fix spurious test_filters.RegionTestCase failures

* Fix spurious test_views.RegionTestCase failures

* Implement Interface Redundancy Groups

* Regenerate migrations to avoid conflict.

* Fix migration numbering.

* Tweaked UI columns.

* Formatted with black.

* Added Region, Site, and Rack to InterfaceRedundancyGroupAssociationForm.

* s/device/interface/g

* Satisfy Flake8 concerns.

* Formatted with Black 23.7.0

* Implement PR suggestions.

* Remove unused imports.

* Removed conditionals from template code.

* Address PR feedback.

* Address PR comments.

* Add CSV import/export to InterfaceRedundancyGroup.

* added unittests and address some feedback

* fix unittests failure

* fix unittests failure and revert commit from develop and address almost all feedback

* additional cleanup

* unittest

* unittest improvements

* reformat InterfaceRedundancyGroup interfaces column

* make InterfaceRedundancyGroupAssociation a ChangeLoggedModel

* merge with develop-1.6

* migration filename changes

* PR feedback

* flake8

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Hanlin Miao <hanlin980505@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Leo Kirchner <Kircheneer@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Check Secret" button nautobot/nautobot
2 participants
@glennmatthews @JostLuebbe