Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network_driver field to Platform model #4136

Closed
glennmatthews opened this issue Jul 18, 2023 · 2 comments · Fixed by #4150
Closed

Add network_driver field to Platform model #4136

glennmatthews opened this issue Jul 18, 2023 · 2 comments · Fixed by #4150
Assignees
Labels
type: feature Introduction of new or enhanced functionality to the application
Milestone

Comments

@glennmatthews
Copy link
Contributor

glennmatthews commented Jul 18, 2023

As ...

Tammy - Tools Integrator

I want ...

To have a consistent way that various apps and libraries (Ansible, Golden Config, etc.) can determine which Netmiko library-specific driver to use when communicating with a given class of devices.

So that ...

Each individual integration does not need to reinvent the wheel, e.g. by adding a custom field or a config-context attribute, in order to solve this common problem.

I know this is done when...

The Platform model allows me to define a netmiko_driver network_driver attribute, similar to the existing napalm_driver attribute, that apps and libraries can consume. See comment below for more specifics.

Optional - Feature groups this request pertains to.

  • Automation
  • DCIM

Database Changes

Yes, new database field.

External Dependencies

None directly - adding this field does not entail making Netmiko into a required dependency of Nautobot.

@glennmatthews glennmatthews added the type: feature Introduction of new or enhanced functionality to the application label Jul 18, 2023
@glennmatthews glennmatthews added this to the v1.6.0 milestone Jul 18, 2023
@glennmatthews glennmatthews self-assigned this Jul 19, 2023
@itdependsnetworks
Copy link
Contributor

I think it makes sense to have:

In this design, it is important to consider:

  • How the REST API will return list view for the methods
  • How the REST API will return detail view for the methods
  • How the GraphQL will return these methods

@glennmatthews glennmatthews changed the title Add netmiko_driver field to Platform model Add network_driver field to Platform model Jul 21, 2023
@glennmatthews glennmatthews linked a pull request Jul 21, 2023 that will close this issue
6 tasks
@gsnider2195
Copy link
Contributor

Completed by #4150

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants