Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status text change to a link when opening object and became unreadable #4280

Closed
martin-networker opened this issue Aug 17, 2023 · 1 comment · Fixed by #4809
Closed

Status text change to a link when opening object and became unreadable #4280

martin-networker opened this issue Aug 17, 2023 · 1 comment · Fixed by #4809
Labels
type: bug Something isn't working as expected

Comments

@martin-networker
Copy link

Environment

  • Nautobot version (Docker tag too if applicable): 2.0.0b2
  • Python version:3.10.9
  • Database platform, version:
  • Middleware(s):

Steps to Reproduce

Thia affects Nautobot 2.0.0b2 it does not happen in 1.5.19.

  1. In GUI open list of prefixes (IPAM > Prefixes) or IP addresses (IPAM > IP Addresses).
  2. Statuses are displayed as white text in colorful frame
  3. Open any prefix/IP and the Stats text became a link which makes it very hard to read when the frame color is darker (red

list view:
image

object view:
image

When opening a specific object, the status should be still a white text.

When opening a specific object, the status became a link (blue color) and become unreadable.

@bryanculver bryanculver added triage This issue is new and has not been reviewed. type: bug Something isn't working as expected labels Aug 17, 2023
@jathanism
Copy link
Contributor

jathanism commented Aug 17, 2023

Hi @martin-networker thanks for the report!

I have confirmed that this is not just unique to IPAddress or Prefix objects, but any object that has a status field. In list view, the style is correct, in detail view it is not.

It is merely a side effect of the fact that in list (table) view, the status field does not link to the status object, whereas in detail view it does.

A simple fix to the CSS for status fields that are linked should do the trick to address this. Specifically in templates this is a result of the hyperlinked_object template filter defined in nautobot/core/templatetags/helpers.py. See:

https://github.com/nautobot/nautobot/blob/next/nautobot/core/templatetags/helpers.py#L703-L708

@jathanism jathanism removed the triage This issue is new and has not been reviewed. label Aug 17, 2023
glennmatthews added a commit that referenced this issue Nov 15, 2023
#4809)

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants