Fix TagFilterField definition to make dynamic-groups happy #4299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #N/A
What's Changed
#4178 added a
to_field_name = "slug"
attribute onTagFilterField
and logic inDynamicGroup.set_filter
that expected allTagFilterField
to have this attribute (TagFilterField
is aMultipleChoiceField
subclass, not aModelMultipleChoiceField
subclass, and so it doesn't natively have anyto_field_name
attribute). When we mergeddevelop
up intonext
(#4271) theto_field_name
line was deleted instead of being updated toto_field_name = "name"
as it should have been. However, the automated tests added in #4178 didn't catch this issue until #4284 fixedDeviceFilterForm
to have atags
TagFilterField
instead of the incorrectly-named-for-2.0tag
field.Solution: add
to_field_name = "name"
to make dynamic-groups happy for now.TODO