Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Integration CI Workflow #4310

Closed
bryanculver opened this issue Aug 23, 2023 · 2 comments
Closed

Update Integration CI Workflow #4310

bryanculver opened this issue Aug 23, 2023 · 2 comments
Assignees
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@bryanculver
Copy link
Member

Proposed Changes

Make the following changes ci_integration.yml

  • Remove ARM from Docker builds
  • Change the unit test matrix to test:
    • Max supported Python version on Postgres DB
    • Min supported Python version on MySQL DB
    • (the above are inverse of PRs for sufficient coverage)
  • Remove linter checks (keep check-schema checks for peace of mind for now)
  • Run Integration Test in parallel with Unit Tests
  • Run Migration Tests in parallel with Unit Tests
  • Add Action keyword to allow manually re-running this workflow on-demand

Justification

  • ARM builds are slow
  • ARM builds of pre-pre-release (latest, develop, etc) builds aren't intended for local (ARM-heavy) or production (lower-cost) use
  • We rarely find intermediate-supported Python failures
    • Either you used too new of a language feature and that would be caught by min test, or
    • You used a potentially deprecated/removed language feature and that would be caught by the max test
  • Lint checks in PRs check the same code, redundant
    • We have "keep PRs up to date" enforcement
  • Integration tests test different things than unit tests and with fail-fast can be grouped together, no point in waiting 30min for unittest only to find out you'll fail integration and need to re-run again
  • Migration tests test different things and are always good to have, but same as integration: you'll have to fix it and might as well cancel unittests if they're going to fail
  • Being able to manually re-run integration tests
@bryanculver bryanculver added type: housekeeping Changes to the application which do not directly impact the end user triage This issue is new and has not been reviewed. labels Aug 23, 2023
@bryanculver
Copy link
Member Author

@bryanculver bryanculver removed the triage This issue is new and has not been reviewed. label Aug 24, 2023
@gsnider2195 gsnider2195 self-assigned this Aug 29, 2023
@gsnider2195
Copy link
Contributor

Completed by #4354

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants