Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI integration workflow #4354

Merged
merged 12 commits into from Aug 30, 2023
Merged

Update CI integration workflow #4354

merged 12 commits into from Aug 30, 2023

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented Aug 30, 2023 •
edited

Closes: #4310

What's Changed

NOTE: This workflow will not be able to be run manually until it is merged into the base branch (develop)

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@gsnider2195 gsnider2195 marked this pull request as draft August 30, 2023 03:58
@gsnider2195 gsnider2195 marked this pull request as ready for review August 30, 2023 14:16
@HanlinMiao HanlinMiao self-assigned this Aug 30, 2023
HanlinMiao
HanlinMiao approved these changes Aug 30, 2023
View reviewed changes
.github/workflows/ci_integration.yml Outdated Show resolved Hide resolved
.github/workflows/ci_integration.yml
@@ -8,124 +8,11 @@ on: # yamllint disable
- "develop"
- "next"
workflow_call:
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for adding this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was part of the requirements of #4310 (allow the workflow to be run manually)

@gsnider2195 gsnider2195 merged commit 9e8a5d6 into next Aug 30, 2023
20 of 21 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-4310-integration-ci-workflow branch August 30, 2023 18:07
@gsnider2195 gsnider2195 mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanlinMiao HanlinMiao HanlinMiao approved these changes

Assignees

@HanlinMiao HanlinMiao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsnider2195 @HanlinMiao