Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove placeholder numbers in new UI #4510

Closed
DistantVoyager opened this issue Sep 22, 2023 · 3 comments · Fixed by #4536
Closed

Remove placeholder numbers in new UI #4510

DistantVoyager opened this issue Sep 22, 2023 · 3 comments · Fixed by #4536
Assignees
@DistantVoyager
Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected UI 2.0
Milestone
v2.0.0

Comments

@DistantVoyager
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): v2.0.0rc3
  • Python version: 3.8

Steps to Reproduce

  1. View new UI home page

Expected Behavior

No value is shown since the logic isn't implemented at this time.

Observed Behavior

Confusing placeholder values are shown.

image
@DistantVoyager DistantVoyager added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. labels Sep 22, 2023
@DistantVoyager DistantVoyager self-assigned this Sep 22, 2023
@DistantVoyager
Copy link
Contributor Author

Recommend changing in order to prevent confusion in 2.0.0 release when someone looks at the new UI.

Currently:
image

Potential Options:
image

image

image

Thoughts? Preferences?

@jathanism
Copy link
Contributor

Thanks for the submission @DistantVoyager! Obviously this panel is still just a mockup, but I can see how it would be confusing or misleading to have numbers show without any actual context.

@jathanism jathanism added UI 2.0 and removed triage This issue is new and has not been reviewed. labels Sep 22, 2023
@DistantVoyager
Copy link
Contributor Author

@jathanism got it - just making sure it doesn't show like that in the final 2.0.0 release

bryanculver added a commit that referenced this issue Sep 27, 2023
@bryanculver
Fix #4510: Remove placeholder tabs, counts on new UI
ab930fb
bryanculver added a commit that referenced this issue Sep 27, 2023
@bryanculver
Fixed #4510: Remove placeholder tabs, counts on new UI
9b6eafe
@bryanculver bryanculver mentioned this issue Sep 27, 2023
Merged
7 tasks
@bryanculver bryanculver added the emergent Unplanned work that is brought into a sprint after it's started. label Sep 27, 2023
bryanculver added a commit that referenced this issue Sep 27, 2023
@bryanculver
Fixes Placeholder and Off-by-one Error in New UI (#4536)
c0bdade 
* Fixed #4535: getMonth returns 0-based instead of 1-based month number.

* Fixed #4510: Remove placeholder tabs, counts on new UI

* Hide instead of remove
@bryanculver bryanculver added this to the v2.0.0 milestone Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DistantVoyager DistantVoyager

Labels
emergent Unplanned work that is brought into a sprint after it's started. type: bug Something isn't working as expected UI 2.0
Projects
No open projects
Nautobot Core ⚙️
Status: Done
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Fixes Placeholder and Off-by-one Error in New UI nautobot/nautobot
3 participants
@bryanculver @jathanism @DistantVoyager