Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyError on custom action not present in PERMISSIONS_ACTION_MAP #4511

Closed
whitej6 opened this issue Sep 22, 2023 · 3 comments · Fixed by #4512
Closed

KeyError on custom action not present in PERMISSIONS_ACTION_MAP #4511

whitej6 opened this issue Sep 22, 2023 · 3 comments · Fixed by #4512
Labels
type: bug Something isn't working as expected

Comments

@whitej6
Copy link
Contributor

whitej6 commented Sep 22, 2023

Environment

  • Nautobot version (Docker tag too if applicable): 2.0.0rc3
  • Python version: 3.11
  • Database platform, version:
  • Middleware(s):

Steps to Reproduce

  1. Create UI viewset with additional action
  2. Attempt to use additional action

Expected Behavior

View works

Observed Behavior

KeyError exception for action not being in PERMISSIONS_ACTION_MAP
@whitej6 whitej6 added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. labels Sep 22, 2023
whitej6 added a commit that referenced this issue Sep 22, 2023
@whitej6
Closes: #4511
7ee0b80
@whitej6 whitej6 mentioned this issue Sep 22, 2023
Merged
7 tasks
@jathanism
Copy link
Contributor

Just for the sake of clarity we're talking about custom view actions derived from viewset methods. Thanks for this submission.

@jathanism jathanism removed the triage This issue is new and has not been reviewed. label Sep 22, 2023
@whitej6
Copy link
Contributor Author

whitej6 commented Sep 27, 2023

Yes

@lampwins
Copy link
Member

lampwins commented Oct 2, 2023

Solving via #4529

@lampwins lampwins closed this as completed Oct 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolved KeyError on custom actions nautobot/nautobot
3 participants
@jathanism @lampwins @whitej6