-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to assign config context to device redundancy group using the REST API #4649
Comments
Looks like you've correctly identified the issue and the proposed fix looks like a solid starting point to me. Would like to have the final code include some test coverage for this issue, but if you'd like to open a PR with your patch we can run with it from there. Thank you! |
As a note, this should be a v1.6-exclusive issue due to changes in how serializers work in v2.0; I'll find some time to test with 2.0 and confirm that this is the case. You should be fine to open your PR against the |
Thanks for being so responsive on this; it's greatly appreciated. Just so I know what to tell our local admins: Do you know about when code including this update will be tagged for release? |
Within a month most likely; possibly sooner than that, but I think we've identified a couple of other items to backport to 1.6 before we cut a new release. Thanks for the fixes! |
Environment
Steps to Reproduce
data
attribute; something like:Note also that there's no
device_redundancy_groups
field visible in the browser REST API interface under `POSTExpected Behavior
Each device should inherit one drg-based config context.
Observed Behavior
Each devices inherits both config contexts, despite the devices being in different device redundancy groups, e.g.:
Possible patch
I've put together the attached patch which works for me, but as I'm almost entirely unfamiliar with the nautobot code base I'm not entirely certain if it's how you'd want to fix it (or if it's complete/correct). Happy to submit a PR if you'd like.
config_context_redundancy_group_api.patch
The text was updated successfully, but these errors were encountered: