Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcr.io/nautobot/nautobot:latest points to a 2.0.0 image #5171

Closed
gsnider2195 opened this issue Jan 25, 2024 · 4 comments · Fixed by #5250
Closed

ghcr.io/nautobot/nautobot:latest points to a 2.0.0 image #5171

gsnider2195 opened this issue Jan 25, 2024 · 4 comments · Fixed by #5250
Assignees
@glennmatthews
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@gsnider2195
Copy link
Contributor

gsnider2195 commented Jan 25, 2024 •
edited

When you run docker run ghcr.io/nautobot/nautobot you shouldn't get such an outdated image. Also, docker.io/networktocode/nautobot:latest doesn't exist so if you run docker pull networktocode/nautobot you get an error:

$ docker pull networktocode/nautobot
Using default tag: latest
Error response from daemon: manifest for networktocode/nautobot:latest not found: manifest unknown: manifest unknown
@gsnider2195 gsnider2195 added type: housekeeping Changes to the application which do not directly impact the end user triage This issue is new and has not been reviewed. labels Jan 25, 2024
@gsnider2195
Copy link
Contributor Author

@bryanculver do you have any background on the latest tag in our container registries? I know we discussed this a while ago.

@glennmatthews
Copy link
Contributor

Related: #4167.

@glennmatthews
Copy link
Contributor

Also #4689.

@lampwins lampwins removed the triage This issue is new and has not been reviewed. label Jan 26, 2024
@bryanculver
Copy link
Member

  • ghcr.io/nautobot/nautobot (continued as GH Nautobot) is a by-product of the package registry association with this Github Org (we could get a token from https://github.com/networktocode to publish to ghcr.io/networktocode)
  • docker.io/networktocode/nautobot (continued as DH Nautobot) I think is a hold-over in how we first created an org in Docker. We should probably consider mirroring to a Nautobot DH org at some point

Assume "as far as I know" and "as far as I remember" for the following:

IMHO:

  • latest should be set in both registries
  • latest should be the latest stable release (so it would move major version upon it's release)
  • stable would be redundant/synonymous with latest

@glennmatthews glennmatthews self-assigned this Feb 7, 2024
glennmatthews added a commit that referenced this issue Feb 7, 2024
@glennmatthews
Fix #5171 - apply 'latest' and 'latest-py' tags to stable releases ra…
64f31fd 
…ther than develop
@glennmatthews glennmatthews mentioned this issue Feb 7, 2024
Merged
4 tasks
glennmatthews added a commit that referenced this issue Feb 12, 2024
@glennmatthews @HanlinMiao
Apply 'latest' and 'latest-py' Docker tags to stable releases rather …
29e043f 
…than `develop` (#5250)

* Fix #5171 - apply 'latest' and 'latest-py' tags to stable releases rather than develop

* Fix latest tag

* Clarify change fragments

* A few more action version bumps

---------

Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>
HanlinMiao added a commit that referenced this issue Feb 21, 2024
@HanlinMiao @gsnider2195
@glennmatthews @timizuoebideri1 @nlgotz @skrobul @Kircheneer @DistantVoyager @tlourey @TLCF @itdependsnetworks @dependabot
Release/2.1.5 (#5305)
fe92dcd 
* Added annotations to document the importance of keeping the TIME_ZONE setting consistent on Nautobot web servers and Celery Beat servers.

* Update nautobot/docs/user-guide/administration/installation/services.md

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* add time zones doc file

* version bump

* switch to threads celery pool, half-fix job result status on gitrepo … (#5265)

* pr feedback

* markdownlint

* Apply 'latest' and 'latest-py' Docker tags to stable releases rather than `develop` (#5250)

* Fix #5171 - apply 'latest' and 'latest-py' tags to stable releases rather than develop

* Fix latest tag

* Clarify change fragments

* A few more action version bumps

---------

Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>

* feat: toggle authentication for /metrics (#5210)

* feat: toggle authentication for /metrics

* chore: added changelog fragment

* fix: remove local testing

* Update changes/5210.added

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* docs: added version prometheus metrics authentication was added

* test: create AuthenticateMetricTestCase to verify that unauth metric access is prevented

* test: test the no authentication required view with an unuathenticated user

* chore: fix wrong message

* chore: run ruff

* fix: use smart_str and change versioning to acceptheaderversioning

* docs: update version

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Enhance resolvePath() to support nested fields (#5244)

* Enhance resolvePath() to support nested fields

This commit updates the resolvePath() function to allow accessing deeply
nested properties within an object using a string path. This enhancement
enables plugin developers to access arbitrary fields in the API response
for custom form rendering, addressing limitations in scenarios like
selecting VLANs for interfaces.

* Extend documentation of ObjectVar

Added few examples of how `display_field` can be used to access complex
structures.

* Update nautobot/docs/development/jobs/index.md

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Improves performance for location detail view. (#5255)

* Improves performance for location detail view.

Co-Authored-By: Glenn Matthews <glenn.matthews@networktocode.com>

* updates

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Fix #5186 - ensure IPAddress.ip_version gets set on save() (#5273)

* Navbar ui fixes (#5268)

* Navbar ui fixes

* Update changes/5267.fixed

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Fixed navbar button spacing with mult buttons

---------

Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* aditional fixes for 5058 in (#5286)

Co-authored-by: TLCF <31373129+TLCF@users.noreply.github.com>

* Fix ordering of IP address tables (#5294)

* Update the low level application stack diagram to orient user traffic… (#5297)

* Update the low level application stack diagram to orient user traffic coming from top.

* Add Canva link

* Update changes/5297.documentation

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Release 2.1.5

* towncrier

* Bump cryptography from 42.0.0 to 42.0.2 (#5303)

* Bump cryptography from 42.0.0 to 42.0.2

Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@42.0.0...42.0.2)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Change fragment

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>

* Update nautobot/docs/release-notes/version-2.1.md

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* added 5303 to the release

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Timizuo <94907097+timizuoebideri1@users.noreply.github.com>
Co-authored-by: Nathan Gotz <775979+nlgotz@users.noreply.github.com>
Co-authored-by: Marek Skrobacki <skrobul@skrobul.com>
Co-authored-by: Leo Kirchner <Kircheneer@users.noreply.github.com>
Co-authored-by: Steven Weiblinger <111259311+DistantVoyager@users.noreply.github.com>
Co-authored-by: TL <9435779+tlourey@users.noreply.github.com>
Co-authored-by: TLCF <31373129+TLCF@users.noreply.github.com>
Co-authored-by: Ken Celenza <ken@celenza.org>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennmatthews glennmatthews

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Status: To Groom
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply 'latest' and 'latest-py' Docker tags to stable releases rather than develop nautobot/nautobot
4 participants
@bryanculver @lampwins @glennmatthews @gsnider2195