Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contacts From ObjectDetailView's return url should redirect to the contacts tab instead of the main tab. #5221

Closed
HanlinMiao opened this issue Feb 2, 2024 · 1 comment
Closed

Add Contacts From ObjectDetailView's return url should redirect to the contacts tab instead of the main tab. #5221

HanlinMiao opened this issue Feb 2, 2024 · 1 comment
Assignees
@HanlinMiao
Labels
type: bug Something isn't working as expected
Milestone
v2.2

Comments

@HanlinMiao
Copy link
Contributor

Proposed Changes

After adding/assigning a contact/team from ObjectDetailView, the web page should be redirected to the contacts tab of the ObjectDetailView instead of the main tab.

Justification

The user can see immediately that the add/assign operations are successful from the contacts tab. Now the user has to click an extra button to navigate to the contacts tab.
@HanlinMiao HanlinMiao added type: housekeeping Changes to the application which do not directly impact the end user triage This issue is new and has not been reviewed. labels Feb 2, 2024
@glennmatthews glennmatthews added type: feature Introduction of new or enhanced functionality to the application and removed type: housekeeping Changes to the application which do not directly impact the end user triage This issue is new and has not been reviewed. labels Feb 5, 2024
@lampwins lampwins added type: bug Something isn't working as expected and removed type: feature Introduction of new or enhanced functionality to the application labels Feb 9, 2024
@lampwins lampwins added this to the v2.2 milestone Feb 9, 2024
@HanlinMiao HanlinMiao self-assigned this Feb 26, 2024
HanlinMiao added a commit that referenced this issue Feb 27, 2024
@HanlinMiao
fixed #5220 and #5221
4140ee9
@HanlinMiao HanlinMiao mentioned this issue Feb 27, 2024
Merged
7 tasks
HanlinMiao added a commit that referenced this issue Mar 5, 2024
@HanlinMiao @gsnider2195
Added data migration to populate default statuses and default roles f…
f59b47e 
…or ContactAssociation model. (#5358)

* fixed #5220 and #5221

* added data migration to populate default statuses and roles for contact association

* removed unused code

* Update changes/5145.added

Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>

* Update changes/5220.fixed

Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>

* address PR feedback

* fix flaky tests

* refactored migration helper methods

* address PR feedback

* address PR feedback

* fix merge conflict

---------

Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
@glennmatthews
Copy link
Contributor

Implemented by #5358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HanlinMiao HanlinMiao

Labels
type: bug Something isn't working as expected
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
3 participants
@lampwins @glennmatthews @HanlinMiao