Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With version 2.1.0, Navigation items now require the permissions arg to be passed #5241

Closed
jmcgill298 opened this issue Feb 7, 2024 · 3 comments · Fixed by #5353
Closed

With version 2.1.0, Navigation items now require the permissions arg to be passed #5241

jmcgill298 opened this issue Feb 7, 2024 · 3 comments · Fixed by #5353
Labels
type: bug Something isn't working as expected

Comments

@jmcgill298
Copy link
Contributor

Environment

  • Nautobot version (Docker tag too if applicable): 2.1.0
  • Python version: 3.8
  • Database platform, version: N/A
  • Middleware(s):

Steps to Reproduce

  1. Have an app with a NavMenuItem that does not pass the permissions argument
  2. Start Nautobot
  3. Login as admin
  4. Click on NavMenuTab where the NavMenuItem should appear
  5. Observe that NavMenuItem does not appear

Expected Behavior

To see the NavMenuItem (or alternatively for the changelog and core Navigation docs to be updated)

Observed Behavior

NavMenuItem was a ghost
@jmcgill298 jmcgill298 added type: bug Something isn't working as expected triage This issue is new and has not been reviewed. labels Feb 7, 2024
@glennmatthews
Copy link
Contributor

Likely a side-effect of #4787.

@glennmatthews
Copy link
Contributor

glennmatthews commented Feb 8, 2024 •
edited

Probably just needs each of the if request.user|has_one_or_more_perms:<permissions list> checks in nautobot/core/templates/inc/nav_menu.html to change to if <permissions_list> and request.user|has_one_or_more_perms:<permissions list>

@glennmatthews glennmatthews removed the triage This issue is new and has not been reviewed. label Feb 8, 2024
@glennmatthews glennmatthews mentioned this issue Feb 26, 2024
Merged
7 tasks
@glennmatthews glennmatthews linked a pull request Feb 26, 2024 that will close this issue
UI and docs updates for plugin-to-App #5353
Merged
7 tasks
@glennmatthews
Copy link
Contributor

glennmatthews commented Mar 7, 2024 •
edited

Fixed for 2.2 by #5353 into next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI and docs updates for plugin-to-App nautobot/nautobot
2 participants
@glennmatthews @jmcgill298