UI and docs updates for plugin-to-App #5353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 26, 2024
glennmatthews
commented
Feb 27, 2024
gsnider2195
reviewed
Feb 27, 2024
gsnider2195
reviewed
Feb 28, 2024
gsnider2195
reviewed
Feb 28, 2024
gsnider2195
reviewed
Feb 28, 2024
gsnider2195
reviewed
Feb 28, 2024
gsnider2195
reviewed
Feb 28, 2024
gsnider2195
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Still seeing some old URL references:
mkdocs.yml:566: - Nautobot Firewall Models: "https://nautobot-plugin-firewall-models.readthedocs.io/en/latest/"
nautobot/docs/apps/index.md:19:|  | [Nautobot Firewall Models](https://nautobot-plugin-firewall-models.readthedocs.io/en/latest/) | Construct firewall policies in Nautobot with the help of the provided collection of relevant models. |
nautobot/docs/apps/index.md:22:|  | [Nautobot Single Source of Truth (SSoT)](https://nautobot-plugin-ssot.readthedocs.io/en/latest/) | Integrate and synchronize data between various "source of truth" (SoT) systems, with Nautobot acting as a central clearinghouse for data - a Single Source of Truth |
Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
glennmatthews
commented
Feb 28, 2024
whitej6
reviewed
Feb 28, 2024
| @@ -60,7 +60,8 @@ | |||
| path("swagger.yaml", SpectacularYAMLAPIView.as_view(), name="schema_yaml"), | |||
| # GraphQL | |||
| path("graphql/", GraphQLDRFAPIView.as_view(), name="graphql-api"), | |||
| # Plugins | |||
| # Apps | |||
| path("apps/", include((apps_api_patterns, "apps-api"))), | |||
There was a problem hiding this comment.
Just to confirm my understanding, would this cause duplicate endpoints?
/api/apps/my-app/mymodel//api/plugins/my-app/mymodel/
There was a problem hiding this comment.
Not currently no, /api/apps/ only contains /installed-apps/ at present. We have a longer-term deliverable to do something with /plugins/app/model/ and /api/plugins/app/model as a generalized solution.
There was a problem hiding this comment.
Thank you for clarifying, was concerned on potential bloat of the openAPI schema generation if all app api endpoints where duplicated.
whitej6
reviewed
Feb 28, 2024
|
|
||
|
|
||
| class InstalledPluginsView(AdminRequiredMixin, View): | ||
| class InstalledAppsView(LoginRequiredMixin, View): |
There was a problem hiding this comment.
Yay!!! UI has the same permissions now!
gsnider2195
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5241
Closes #5341
What's Changed
/apps/installed-apps/URL patterns (just a mirror of/plugins/installed-plugins/for now)/api/apps/installed-apps/URL patterns (just a mirror of/api/apps/installed-apps/for now)Apprather thanpluginterminology throughoutApprather thanpluginterminology throughoutis_staffrestriction to access the "Installed Apps" view (irrelevant since similar information is exposed via the/api/status/endpoint accessible to any authenticated user)Screenshots
TODO