Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Sync - Include Commit Hash on Sync Page #623

Closed
jvanderaa opened this issue Jun 25, 2021 · 6 comments · Fixed by #922
Closed

Git Sync - Include Commit Hash on Sync Page #623

jvanderaa opened this issue Jun 25, 2021 · 6 comments · Fixed by #922
Assignees
@jeffkala
Labels
good first issue Great issues for newcomers! type: feature Introduction of new or enhanced functionality to the application

Comments

@jvanderaa
Copy link
Contributor

Environment

  • Python version: 3.6
  • Nautobot version: 1.0.3

Proposed Functionality

Add the Git hash to the git sync output display

Use Case

To be able to verify the commit hash matches the version that is expected for troubleshooting.

Database Changes

None

External Dependencies

None
@glennmatthews glennmatthews added good first issue Great issues for newcomers! status: needs owner type: feature Introduction of new or enhanced functionality to the application labels Jun 29, 2021
@glennmatthews
Copy link
Contributor

Thank you for the request! I agree this would be useful information to include in the JobResult logging, and should be relatively simple to add.

@jeffkala
Copy link
Contributor

jeffkala commented Jul 9, 2021

@glennmatthews @jvanderaa I'd like to give this one a shot.

@glennmatthews
Copy link
Contributor

Terrific! By all means go for it.

@jedelman8
Copy link
Contributor

@jeffkala what's your timing on this? If it is in the next 2-3 weeks, it'll make 1.2, otherwise, 1.3. Can you let us know? :)

@jeffkala
Copy link
Contributor

@jedelman8 , pretty sure I can get this in the next 2-3 weeks.

jeffkala added a commit to jeffkala/nautobot that referenced this issue Sep 17, 2021
@jeffkala
fixes nautobot#623 add commit has to job results logging
87614dc
@jeffkala jeffkala mentioned this issue Sep 17, 2021
Merged
@jeffkala
Copy link
Contributor

@jedelman8 PR is in, was actually much simpler than I thought to implement it.

glennmatthews pushed a commit that referenced this issue Sep 24, 2021
@jeffkala
Add Commit Hash on Sync Page for Git Repositories (#922)
66519b1 
* fixes #623 add commit hash to job results logging

* have hash log earlier in outputs
glennmatthews added a commit that referenced this issue Sep 24, 2021
@glennmatthews
Add release-notes for #623 and #861
64fb2a2
@glennmatthews glennmatthews mentioned this issue Sep 30, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffkala jeffkala

Labels
good first issue Great issues for newcomers! type: feature Introduction of new or enhanced functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Commit Hash on Sync Page for Git Repositories jeffkala/nautobot
4 participants
@glennmatthews @jedelman8 @jvanderaa @jeffkala