Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slug field in Computed Field form doesn't behave like other slug fields #683

Closed
dgarros opened this issue Jul 13, 2021 · 4 comments · Fixed by #761
Closed

slug field in Computed Field form doesn't behave like other slug fields #683

dgarros opened this issue Jul 13, 2021 · 4 comments · Fixed by #761
Labels
type: bug Something isn't working as expected

Comments

@dgarros
Copy link
Contributor

dgarros commented Jul 13, 2021

Environment

  • Python version: sandbox
  • Nautobot version: 1.1.0b2

Steps to Reproduce

  1. create a new computed field via the UI

Observed Behavior

The slug field in the computed field form is not behaving like the other slug field in Nautobot where the field auto-populate based on the value of the label or the name
Currently the Slug field is first and it's behaving like a regular field not a slug field.

Screen Shot 2021-07-13 at 7 04 24 PM

Expected Behavior

The label field should be listed first in the form and the slug field should auto populate based on the value of the label field

Looking at the code, the ComputedFieldForm is not defining slug = SlugField()

https://github.com/nautobot/nautobot/blob/develop/nautobot/extras/forms.py#L995

@glennmatthews glennmatthews added status: under review type: bug Something isn't working as expected labels Jul 14, 2021
@FragmentedPacket
Copy link
Contributor

I can take this one as well when it gets accepted.

I assume we'll want label to be displayed above slug as well to match other forms?

@smk4664
Copy link
Contributor

smk4664 commented Jul 15, 2021

@FragmentedPacket If you wouldn't mind, I am already working another slug related issue, and can fix this while I am at it.

@jathanism
Copy link
Contributor

@FragmentedPacket If you wouldn't mind, I am already working another slug related issue, and can fix this while I am at it.

Hey. Do it! 😎

@smk4664
Copy link
Contributor

smk4664 commented Aug 1, 2021

My other issue is going to target a future release, so I am moving this into its own fix.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants