Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading documentation doesn't mention Celery migration #843

Closed
glennmatthews opened this issue Aug 23, 2021 · 1 comment · Fixed by #1147
Closed

Upgrading documentation doesn't mention Celery migration #843

glennmatthews opened this issue Aug 23, 2021 · 1 comment · Fixed by #1147
Assignees
@glennmatthews
Labels
type: bug Something isn't working as expected type: documentation Improvements or additions to documentation

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Python version: any
  • Nautobot version: 1.0.x upgrading to 1.1.x

Steps to Reproduce

  1. Follow the upgrade steps as documented at https://nautobot.readthedocs.io/en/stable/installation/upgrading/ to migrate from Nautobot 1.0.x to 1.1.x
  2. Background tasks no longer work because the Celery worker hasn't been added and enabled.

Expected Behavior

"Upgrading" documentation needs to include all appropriate steps for the upgrade, which in the 1.0 -> 1.1 case includes enabling Celery and optionally disabling RQ. This might be as simple as adding a paragraph of text plus a link to https://nautobot.readthedocs.io/en/stable/installation/services/#setup-systemd, in this particular case?

Observed Behavior

No mention of Celery on this page.
@glennmatthews glennmatthews added type: bug Something isn't working as expected type: documentation Improvements or additions to documentation status: accepted labels Aug 23, 2021
@glennmatthews
Copy link
Contributor Author

In 1.2 we'll similarly need to add content to this page about enabling Celery Beat as well.

@glennmatthews glennmatthews self-assigned this Dec 10, 2021
glennmatthews added a commit that referenced this issue Dec 10, 2021
@glennmatthews
Add note calling out the RQ-to-Celery migration in 1.1.x. Fixes #843
a1ba972
@glennmatthews glennmatthews mentioned this issue Dec 10, 2021
Merged
glennmatthews added a commit that referenced this issue Dec 13, 2021
@glennmatthews
Add note calling out the RQ-to-Celery migration in 1.1.x. Fixes #843 (#…
6a9d533 
…1147)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: bug Something isn't working as expected type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: add note calling out the RQ-to-Celery migration in 1.1.x. nautobot/nautobot
1 participant
@glennmatthews