Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HotFix: error at CableCSVForm.add_error #1308

Merged
merged 1 commit into from
Feb 2, 2022
Merged

HotFix: error at CableCSVForm.add_error #1308

merged 1 commit into from
Feb 2, 2022

Conversation

timizuoebideri1
Copy link
Contributor

@timizuoebideri1 timizuoebideri1 commented Jan 25, 2022 •
edited
Loading

Fixes: #1297

Fixed AttributeError error raised when error: ValidationError parameter in CableCSVForm.add_error has no error_dict

@timizuoebideri1
Fix error at CableCSVForm.add_error
856f54b 
An Exception is triggered when error has no error_dict property
@timizuoebideri1 timizuoebideri1 changed the title Fix error at CableCSVForm.add_error HotFix: error at CableCSVForm.add_error Jan 26, 2022
glennmatthews
glennmatthews reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change. Is there a specific problem that this is a fix for, and if so are there any new unit tests that should be added?

@timizuoebideri1
Copy link
Contributor Author

timizuoebideri1 commented Jan 26, 2022 •
edited
Loading

Looks like a reasonable change. Is there a specific problem that this is a fix for, and if so are there any new unit tests that should be added?

Yea, My previous PR https://github.com/nautobot/nautobot/pull/1297, i did not check for this edge case.

@glennmatthews glennmatthews merged commit b5abb97 into develop Feb 2, 2022
@glennmatthews glennmatthews deleted the timizuo-fix-cable-csv-form-add-error branch February 2, 2022 15:38
glennmatthews added a commit that referenced this pull request Feb 2, 2022
@glennmatthews
Add release-note for #1308 [skip ci]
0ef0d9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timizuoebideri1 @glennmatthews