Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static (JS/CSS) dependencies #1321

Merged
merged 8 commits into from
Feb 2, 2022

Conversation

glennmatthews
Copy link
Contributor

Fixes: #N/A

Loosely related to #1097.

  • For select2 all we actually need/use are select2.min.js, select2.min.css, and a set of i18n files, so I removed a ton of unused files (mostly documentation, source files, and test code) from this subdirectory.
  • Update materialdesignicons to latest available version. This is technically a breaking change as moving from 5.x to 6.x results in a small number of icons being removed and a similarly small number of icons being renamed; AFAICT we're not using any of the impacted icons but there could theoretically be an impact to a plugin. If this gives heartburn I can replace this with the latest 5.x version of materialdesignicons instead, but my feeling is that the risk is very low.
  • Update flatpickr to latest available
  • Update jquery-ui to latest available (yes, there's a new version of jquery-ui!)
  • Update clipboard.js to latest available.

Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@glennmatthews glennmatthews merged commit 8222c19 into next Feb 2, 2022
@glennmatthews glennmatthews deleted the gfm-update-static-dependencies branch February 2, 2022 18:06
timizuoebideri1 pushed a commit that referenced this pull request Feb 9, 2022
* Remove unnecessary select2 files

* materialdesignicons 5.4.55 -> 6.5.95

* flatpickr 4.6.3 -> 4.6.9

* jquery-ui 1.12.1 -> 1.13.1

* clipboard.js 2.0.6 -> 2.0.9

* Re-add select2 i18n files

* Update release-note [skip ci]
@bryanculver bryanculver added this to the v1.3.0 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants