Improving the MySQL developer experience with Nautobot #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 17, 2022
| @@ -0,0 +1,2 @@ | |||
| -- Allow the nautobot user to create databases, this is required to run unittests | |||
There was a problem hiding this comment.
Do you know why this isn't needed in our CI environment? Is it because there we're defaulting to the root user instead of the nautobot user?
There was a problem hiding this comment.
You are 100% correct https://github.com/nautobot/nautobot/blob/develop/.github/workflows/ci.yml#L127
glennmatthews
approved these changes
Mar 17, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier and faster to switch between postgres and MySQL database backends in your development environment. We do mainly 2 things here, first we name the database host 'db' across both postgres and MySQL environments so we don't have to change env vars. Secondly we grant the nautobot MySQL user permissions to create databases allowing the unit tests to pass.