Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the advanced logging example #1517

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

ubajze
Copy link
Contributor

@ubajze ubajze commented Mar 17, 2022

The original example can leak passwords if passwords are sent in a request body. This happens at login for example. We should mask passwords.

@bryanculver
Copy link
Member

@ubajze Are there other places where passwords maybe logged? Say some things like golden config, etc? Reason I ask is that it might be helpful to show a before/after of the log message so if an administrator needs to extend this further, they can potentially understand better how mask_password sees the record message and is modifying it.

@ubajze
Copy link
Contributor Author

ubajze commented Mar 17, 2022

@bryanculver I am pretty sure there are other places where passwords can be leaked. I updated the text a little bit.

@bryanculver
Copy link
Member

@ubajze With the two suggestions above, I think this should be GTG.

Co-authored-by: Uros Bajzelj <ubajze@users.noreply.github.com>
@bryanculver bryanculver merged commit c075efb into develop Mar 21, 2022
bryanculver added a commit that referenced this pull request Mar 21, 2022
@ubajze ubajze deleted the ub_logging_example_update branch March 22, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants